You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/18 10:33:42 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #9579: fix:
Add deprecated fields to QueryObject schema
villebro opened a new pull request #9579: fix: Add deprecated fields to QueryObject schema
URL: https://github.com/apache/incubator-superset/pull/9579
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [x] Documentation
### SUMMARY
The new chart data API and `QueryContext` class didn't fully support the current request payload being sent by visualization plugins. This adds the missing fields and expands the existing unit tests.
### TEST PLAN
CI
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@suddjian
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9579:
fix: Add deprecated fields to QueryObject schema
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9579: fix: Add deprecated fields to QueryObject schema
URL: https://github.com/apache/incubator-superset/pull/9579#issuecomment-615839208
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=h1) Report
> Merging [#9579](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **increase** coverage by `4.49%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9579 +/- ##
==========================================
+ Coverage 65.62% 70.11% +4.49%
==========================================
Files 574 574
Lines 30060 30075 +15
Branches 3054 3054
==========================================
+ Hits 19726 21087 +1361
+ Misses 10150 8870 -1280
+ Partials 184 118 -66
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.88% <ø> (?)` | |
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.21% <88.88%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `93.40% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.79% <100.00%> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| ... and [144 more](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=footer). Last update [ea27e68...ed0b92a](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9579:
fix: Add deprecated fields to QueryObject schema
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9579: fix: Add deprecated fields to QueryObject schema
URL: https://github.com/apache/incubator-superset/pull/9579#issuecomment-615839208
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=h1) Report
> Merging [#9579](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9579 +/- ##
==========================================
- Coverage 65.62% 65.48% -0.14%
==========================================
Files 574 574
Lines 30060 30075 +15
Branches 3054 3054
==========================================
- Hits 19726 19695 -31
- Misses 10150 10196 +46
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.21% <88.88%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `93.40% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.79% <100.00%> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=footer). Last update [ea27e68...ed0b92a](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #9579: fix: Add
deprecated fields to QueryObject schema
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #9579: fix: Add deprecated fields to QueryObject schema
URL: https://github.com/apache/incubator-superset/pull/9579
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9579: fix: Add
deprecated fields to QueryObject schema
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9579: fix: Add deprecated fields to QueryObject schema
URL: https://github.com/apache/incubator-superset/pull/9579#issuecomment-615839208
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=h1) Report
> Merging [#9579](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **decrease** coverage by `6.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9579 +/- ##
==========================================
- Coverage 65.62% 58.75% -6.87%
==========================================
Files 574 392 -182
Lines 30060 12414 -17646
Branches 3054 3054
==========================================
- Hits 19726 7294 -12432
+ Misses 10150 4936 -5214
Partials 184 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | | |
| [superset/utils/log.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | | |
| [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | | |
| [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | | |
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | | |
| [superset/common/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3RhZ3MucHk=) | | |
| [superset/views/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZmlsdGVycy5weQ==) | | |
| [superset/examples/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvX19pbml0X18ucHk=) | | |
| ... and [169 more](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=footer). Last update [ea27e68...ed0b92a](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9579:
fix: Add deprecated fields to QueryObject schema
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9579: fix: Add deprecated fields to QueryObject schema
URL: https://github.com/apache/incubator-superset/pull/9579#issuecomment-615839208
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=h1) Report
> Merging [#9579](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **increase** coverage by `4.83%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9579 +/- ##
==========================================
+ Coverage 65.62% 70.46% +4.83%
==========================================
Files 574 574
Lines 30060 30075 +15
Branches 3054 3054
==========================================
+ Hits 19726 21191 +1465
+ Misses 10150 8773 -1377
+ Partials 184 111 -73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.71% <ø> (?)` | |
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.43% <88.88%> (-0.02%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `93.40% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.79% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `56.98% <0.00%> (+1.07%)` | :arrow_up: |
| [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=) | `81.69% <0.00%> (+1.40%)` | :arrow_up: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <0.00%> (+1.69%)` | :arrow_up: |
| ... and [138 more](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=footer). Last update [ea27e68...ed0b92a](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9579:
fix: Add deprecated fields to QueryObject schema
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9579: fix: Add deprecated fields to QueryObject schema
URL: https://github.com/apache/incubator-superset/pull/9579#issuecomment-615839208
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=h1) Report
> Merging [#9579](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **increase** coverage by `4.85%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9579 +/- ##
==========================================
+ Coverage 65.62% 70.48% +4.85%
==========================================
Files 574 574
Lines 30060 30075 +15
Branches 3054 3054
==========================================
+ Hits 19726 21197 +1471
+ Misses 10150 8767 -1383
+ Partials 184 111 -73
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.71% <ø> (?)` | |
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.47% <88.88%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `93.40% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.79% <100.00%> (ø)` | |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `56.98% <0.00%> (+1.07%)` | :arrow_up: |
| [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=) | `81.69% <0.00%> (+1.40%)` | :arrow_up: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <0.00%> (+1.69%)` | :arrow_up: |
| [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | `69.64% <0.00%> (+1.78%)` | :arrow_up: |
| ... and [137 more](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=footer). Last update [ea27e68...ed0b92a](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9579:
fix: Add deprecated fields to QueryObject schema
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9579: fix: Add deprecated fields to QueryObject schema
URL: https://github.com/apache/incubator-superset/pull/9579#issuecomment-615839208
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=h1) Report
> Merging [#9579](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea27e68ee1c746b0daa831765bbadb81a6b2ed0d&el=desc) will **increase** coverage by `4.62%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9579 +/- ##
==========================================
+ Coverage 65.62% 70.24% +4.62%
==========================================
Files 574 574
Lines 30060 30075 +15
Branches 3054 3054
==========================================
+ Hits 19726 21126 +1400
+ Misses 10150 8831 -1319
+ Partials 184 118 -66
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.88% <ø> (?)` | |
| #javascript | `58.75% <ø> (ø)` | |
| #python | `70.43% <88.88%> (-0.02%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `93.40% <80.00%> (-0.50%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.79% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (+0.65%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (+1.28%)` | :arrow_up: |
| [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=) | `81.69% <0.00%> (+1.40%)` | :arrow_up: |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
| [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
| ... and [136 more](https://codecov.io/gh/apache/incubator-superset/pull/9579/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=footer). Last update [ea27e68...ed0b92a](https://codecov.io/gh/apache/incubator-superset/pull/9579?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org