You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/08 15:41:25 UTC

[GitHub] [incubator-nuttx] yunkya2 opened a new pull request #3002: arm/rp2040: SPI driver DMA transfer support

yunkya2 opened a new pull request #3002:
URL: https://github.com/apache/incubator-nuttx/pull/3002


   ## Summary
   Support DMA transfer for RP2040 SPI driver.
   
   ## Impact
   rp2040 only
   
   ## Testing
   Tested with `raspberrypi-pico:spisd` configuration.
   Read/Write access OK.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #3002: arm/rp2040: SPI driver DMA transfer support

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3002:
URL: https://github.com/apache/incubator-nuttx/pull/3002#issuecomment-793059317


   Hi @yunkya2 about "Tested with raspberrypi-pico:spisd configuration" how much it improved the speed? Did you do some measurements? BR, Alan


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yunkya2 commented on pull request #3002: arm/rp2040: SPI driver DMA transfer support

Posted by GitBox <gi...@apache.org>.
yunkya2 commented on pull request #3002:
URL: https://github.com/apache/incubator-nuttx/pull/3002#issuecomment-793162156


   @acassis I have tested by writing/reading 10MB file.
   
   Without DMA: (`CONFIG_RP2040_SPI_DMA is not set`)
   ```
   nsh> rm test
   nsh> time "dd if=/dev/zero of=test bs=32768 count=320"
   
   6.5500 sec
   
   nsh> time "dd if=test of=/dev/null bs=32768 count=320"
   
   5.6200 sec
   ```
   - Write: 12.8Mbps
   - Read: 14.9Mbps
   
    
   With DMA: (`CONFIG_RP2040_SPI_DMA=y`)
   ```
   nsh> rm test
   nsh> time "dd if=/dev/zero of=test bs=32768 count=320"
   
   6.1800 sec
   
   nsh> time "dd if=test of=/dev/null bs=32768 count=320"
   
   5.2500 sec
   ```
   
   - Write: 13.6Mbps
   - Read: 16.0Mbps
   
   The performance improvement is not so high.
   Rather than it, the major improvement is the decrease of CPU load while transfer.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #3002: arm/rp2040: SPI driver DMA transfer support

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #3002:
URL: https://github.com/apache/incubator-nuttx/pull/3002


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3002: arm/rp2040: SPI driver DMA transfer support

Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #3002:
URL: https://github.com/apache/incubator-nuttx/pull/3002#issuecomment-793220170


   I see! Thank you @yunkya2 ! Any improvement is a good progress! Yes, the decrease of the CPU load is the best result!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #3002: arm/rp2040: SPI driver DMA transfer support

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3002:
URL: https://github.com/apache/incubator-nuttx/pull/3002#issuecomment-793220170


   I see! Thank you @yunkya2 ! Any improvement is a good progress! Ye the decrease of the CPU load is the best result!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org