You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/03/16 16:07:40 UTC
Review Request 32105: Added << operator to stout.flags.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
see summary
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing
-------
Thanks,
Joerg Schad
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Michael Park <mc...@gmail.com>.
> On March 26, 2015, 2:57 a.m., Michael Park wrote:
> > Are we changing the format to be "--key0=val0 --key1=val1 --key2=val2"?
>
> Joerg Schad wrote:
> Yes, following the discussion with BenM on the Jira.
Ah ok, thanks!
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77859
-----------------------------------------------------------
On March 26, 2015, 8:29 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 8:29 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On March 26, 2015, 2:57 a.m., Michael Park wrote:
> > Are we changing the format to be "--key0=val0 --key1=val1 --key2=val2"?
Yes, following the discussion with BenM on the Jira.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77859
-----------------------------------------------------------
On March 25, 2015, 11:20 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 11:20 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77859
-----------------------------------------------------------
Are we changing the format to be "--key0=val0 --key1=val1 --key2=val2"?
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
<https://reviews.apache.org/r/32105/#comment126183>
Oops, looks like you lost an indent here.
- Michael Park
On March 25, 2015, 11:20 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 11:20 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review78044
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
<https://reviews.apache.org/r/32105/#comment126435>
`iostream` is quite a big header, can you change it to `ostream`. I feel it does everything we need.
- Alexander Rojas
On March 26, 2015, 9:29 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 9:29 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77906
-----------------------------------------------------------
LGTM!
- Michael Park
On March 26, 2015, 8:29 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 8:29 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
-----------------------------------------------------------
(Updated March 27, 2015, 2:49 p.m.)
Review request for mesos.
Changes
-------
Adressed Alexnders comment and reduced include (iosteam -> ostream)
Bugs: Mesos-2323
https://issues.apache.org/jira/browse/Mesos-2323
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
-----------------------------------------------------------
(Updated March 26, 2015, 8:29 a.m.)
Review request for mesos.
Changes
-------
Style fix
Bugs: Mesos-2323
https://issues.apache.org/jira/browse/Mesos-2323
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
-----------------------------------------------------------
(Updated March 25, 2015, 11:20 p.m.)
Review request for mesos.
Changes
-------
Adressed Bens and Michaels comments.
Bugs: Mesos-2323
https://issues.apache.org/jira/browse/Mesos-2323
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77723
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On March 17, 2015, 12:25 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 12:25 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review76706
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 17, 2015, 12:25 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 12:25 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On March 23, 2015, 5:44 p.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 588-603
> > <https://reviews.apache.org/r/32105/diff/4/?file=897000#file897000line588>
> >
> > As I see you create the body of a json object where all the elements are strings themselves, ignoring their actual types and in [30931](https://reviews.apache.org/r/30931/diff/) the outer brackets are added completing the json object.
> >
> > In the endpoints, for example [here](https://github.com/apache/mesos/blob/0c7104d4d83d28371db7d19dcbb1bf077eeede05/src/master/http.cpp#L108) we use a patter for serialisation where we create a json object through a `model` function, and then we serialise the resulting json.
> >
> > Is there a reason why that approach wouln't work here?
In the rest of stout we use the operator >> version for printing stuff. I in general like the idea of a general model function, but it also looks slightly less intuitive when printing the flags to the log (see code below).
For this patch I refere the operator solution for consistency with the rest of stout.
flags.hpp
inline JSON::Object model(const FlagsBase& _flags)
{
JSON::Object flags;
foreachvalue (const flags::Flag& flag, _flags) {
const Option<std::string>& value = flag.stringify(_flags);
if (value.isSome()) {
flags.values[flag.name] = value.get();
}
}
return flags;
}
slave/master
LOG(INFO) << "Flags at startup: {" << flags::model(flags) << "}";
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77426
-----------------------------------------------------------
On March 17, 2015, 12:25 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 12:25 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77426
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
<https://reviews.apache.org/r/32105/#comment125485>
As I see you create the body of a json object where all the elements are strings themselves, ignoring their actual types and in [30931](https://reviews.apache.org/r/30931/diff/) the outer brackets are added completing the json object.
In the endpoints, for example [here](https://github.com/apache/mesos/blob/0c7104d4d83d28371db7d19dcbb1bf077eeede05/src/master/http.cpp#L108) we use a patter for serialisation where we create a json object through a `model` function, and then we serialise the resulting json.
Is there a reason why that approach wouln't work here?
- Alexander Rojas
On March 17, 2015, 1:25 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 1:25 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Till Toenshoff <to...@me.com>.
> On March 25, 2015, 3:30 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 592-600
> > <https://reviews.apache.org/r/32105/diff/4/?file=897000#file897000line592>
> >
> > How about breaking this up in order to avoid the ad-hoc `join` code?
> >
> > ```
> > std::vector<std::string> flags;
> >
> > foreachvalue (const flags::Flags& flag, _flags) {
> > const Option<std::string>& value = flag.stringify(_flags);
> > if (value.isSome()) {
> > flags.push_back(value.get());
> > }
> > }
> >
> > return stream << join(",", flags);
> > ```
THat is a good approach indeed. Wont look just as nice as your example as we need `key + '=' + '"' + value + '"'` , not just the value.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77735
-----------------------------------------------------------
On March 17, 2015, 12:25 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 12:25 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Michael Park <mc...@gmail.com>.
> On March 25, 2015, 3:30 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines 592-600
> > <https://reviews.apache.org/r/32105/diff/4/?file=897000#file897000line592>
> >
> > How about breaking this up in order to avoid the ad-hoc `join` code?
> >
> > ```
> > std::vector<std::string> flags;
> >
> > foreachvalue (const flags::Flags& flag, _flags) {
> > const Option<std::string>& value = flag.stringify(_flags);
> > if (value.isSome()) {
> > flags.push_back(value.get());
> > }
> > }
> >
> > return stream << join(",", flags);
> > ```
>
> Till Toenshoff wrote:
> THat is a good approach indeed. Wont look just as nice as your example as we need `key + '=' + '"' + value + '"'` , not just the value.
Yeah, Joerg pinged me offline about it. I mistakenly left out the `key`, but the point got across :)
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77735
-----------------------------------------------------------
On March 25, 2015, 11:20 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 11:20 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Michael Park <mc...@gmail.com>.
> On March 25, 2015, 3:30 p.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 597
> > <https://reviews.apache.org/r/32105/diff/4/?file=897000#file897000line597>
> >
> > `s/<<"\""/<< "\""/` in both occurrences.
Also, do we have a rule that we can't use `char` literals? I think `'"'` is nicer than `"\""`.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77735
-----------------------------------------------------------
On March 17, 2015, 12:25 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 12:25 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review77735
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
<https://reviews.apache.org/r/32105/#comment125927>
Looks like this fits in 80 columns.
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
<https://reviews.apache.org/r/32105/#comment125929>
How about breaking this up in order to avoid the ad-hoc `join` code?
```
std::vector<std::string> flags;
foreachvalue (const flags::Flags& flag, _flags) {
const Option<std::string>& value = flag.stringify(_flags);
if (value.isSome()) {
flags.push_back(value.get());
}
}
return stream << join(",", flags);
```
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
<https://reviews.apache.org/r/32105/#comment125926>
`s/<<"\""/<< "\""/` in both occurrences.
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
<https://reviews.apache.org/r/32105/#comment125928>
Remove empty line
- Michael Park
On March 17, 2015, 12:25 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 12:25 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
-----------------------------------------------------------
(Updated March 17, 2015, 12:25 a.m.)
Review request for mesos.
Changes
-------
Adressed Alex comments
Bugs: Mesos-2323
https://issues.apache.org/jira/browse/Mesos-2323
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On March 16, 2015, 6:52 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 589
> > <https://reviews.apache.org/r/32105/diff/3/?file=896108#file896108line589>
> >
> > I think you need to `#include <iosfwd>`.
Sorry, you'll need the whole `<iostream>`. That's the consequence of having definitions in headers.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review76602
-----------------------------------------------------------
On March 16, 2015, 6:11 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 6:11 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/#review76602
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
<https://reviews.apache.org/r/32105/#comment124169>
We do not use `using` directive in headers unless we want to alias a standard type in our own namespace.
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
<https://reviews.apache.org/r/32105/#comment124177>
I think you need to `#include <iosfwd>`.
- Alexander Rukletsov
On March 16, 2015, 6:11 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32105/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 6:11 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: Mesos-2323
> https://issues.apache.org/jira/browse/Mesos-2323
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
>
> Diff: https://reviews.apache.org/r/32105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
-----------------------------------------------------------
(Updated March 16, 2015, 6:11 p.m.)
Review request for mesos.
Changes
-------
style fix
Bugs: Mesos-2323
https://issues.apache.org/jira/browse/Mesos-2323
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
-----------------------------------------------------------
(Updated March 16, 2015, 4:13 p.m.)
Review request for mesos.
Changes
-------
improved style...
Bugs: Mesos-2323
https://issues.apache.org/jira/browse/Mesos-2323
Repository: mesos
Description
-------
see summary
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
-----------------------------------------------------------
(Updated March 16, 2015, 3:22 p.m.)
Review request for mesos.
Changes
-------
added testing
Bugs: Mesos-2323
https://issues.apache.org/jira/browse/Mesos-2323
Repository: mesos
Description
-------
see summary
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing (updated)
-------
make check
Thanks,
Joerg Schad
Re: Review Request 32105: Added << operator to stout.flags.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32105/
-----------------------------------------------------------
(Updated March 16, 2015, 3:10 p.m.)
Review request for mesos.
Bugs: Mesos-2323
https://issues.apache.org/jira/browse/Mesos-2323
Repository: mesos
Description
-------
see summary
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp aedb6ab30d929b81f55270612e76009bd7850daa
Diff: https://reviews.apache.org/r/32105/diff/
Testing
-------
Thanks,
Joerg Schad