[GitHub] [hbase] apurtell commented on a change in pull request #3640: HBASE-25588 Excessive logging of "hbase.zookeeper.useMulti is deprecated. Default to true always."

[GitBox <gi...@apache.org>]

apurtell commented on a change in pull request #3640:
URL: https://github.com/apache/hbase/pull/3640#discussion_r698593228



##########
File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##########
@@ -1760,6 +1760,10 @@ private static Op toZooKeeperOp(ZKWatcher zkw, ZKUtilOp op) throws UnsupportedOp
     }
   }
 
+  // Static boolean for warning about useMulti because we only want one warning per process
+  // instance.
+  private static boolean useMultiWarn = true;

Review comment:
       Makes sense. The thing that this static boolean controls, whether or not to log a warning, is trivial, so consequences for any multithreaded concern is also trivial. I will add a comment to this effect. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org