[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #16229: [Doc][Cli] Add explanations for topic retention policy.

[GitBox <gi...@apache.org>]

michaeljmarshall commented on code in PR #16229:
URL: https://github.com/apache/pulsar/pull/16229#discussion_r910611711


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopicPolicies.java:
##########
@@ -449,7 +449,8 @@ private class GetRetention extends CliCommand {
         private boolean applied = false;
 
         @Parameter(names = { "--global", "-g" }, description = "Whether to get this policy globally. "
-                + "If set to true, broker returned global topic policies")
+                + "If set to true, the broker returns global topic policies"

Review Comment:
   Nit: this line is missing a period and a trailing space. When the current annotation is output for the `bin/pulsar-admin topics` help command, it will have `policiesIf` instead of `policies. If`



##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopicPolicies.java:
##########
@@ -507,7 +509,8 @@ private class RemoveRetention extends CliCommand {
         private List<String> params;
 
         @Parameter(names = { "--global", "-g" }, description = "Whether to remove this policy globally. "
-                + "If set to true, the removing operation will be replicate to other clusters asynchronously")
+                + "If set to true, the removing operation is replicated to other clusters asynchronously"

Review Comment:
   Same comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org