You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/12/20 04:38:17 UTC
Review Request 29289: libprocess: Created IP address abstraction for
different protocol families
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Dominic Hamon.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
The Address can be in NETWORK or BYTE order.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp 7e1e3f22583f44a9aea8259bafedc2877ad2e633
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 028b33e7ecb7e0a39334ac4ab0279ee327a72a56
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Jan. 27, 2015, 3:41 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, lines 127-129
> > <https://reviews.apache.org/r/29289/diff/9/?file=834358#file834358line127>
> >
> > Would it make sense to provide a constructor in net::IP::InAddrStorage that takes family, or an enum and default constructs correctly? This seems like a repetitive, error prone pattern right now.
added a static fcatory method fromFamily.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review69741
-----------------------------------------------------------
On Jan. 28, 2015, 9:57 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 9:57 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Jan. 27, 2015, 3:41 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 74
> > <https://reviews.apache.org/r/29289/diff/9/?file=834358#file834358line74>
> >
> > It seems like we have helper functions to deal with addresses now that switch on the family and abstract these kinds of things away.
> > Can we follow the same pattern and not have exceptions like this one? If we add another family then this will likely be missed and turn into a bug.
created sizeofSocketAddress
> On Jan. 27, 2015, 3:41 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 132
> > <https://reviews.apache.org/r/29289/diff/9/?file=834358#file834358line132>
> >
> > I don't know what the style rule is from `(sockaddr_in6*)`, but it's inconsistent with the case above.
i left *(sockaddr_in6*)
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review69741
-----------------------------------------------------------
On Jan. 27, 2015, 4:58 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 4:58 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review69741
-----------------------------------------------------------
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/29289/#comment114508>
Let's take `_ip` by constant reference now that it's larger than 8 bytes.
3rdparty/libprocess/include/process/pid.hpp
<https://reviews.apache.org/r/29289/#comment114509>
const ref.
3rdparty/libprocess/include/process/pid.hpp
<https://reviews.apache.org/r/29289/#comment114510>
const ref.
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment114511>
Missing period.
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment114512>
Missing period.
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment114513>
It seems like we have helper functions to deal with addresses now that switch on the family and abstract these kinds of things away.
Can we follow the same pattern and not have exceptions like this one? If we add another family then this will likely be missed and turn into a bug.
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment114514>
same as above.
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment114515>
Can we change this error style to "on: " + stringify(node)?
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment114519>
Would it make sense to provide a constructor in net::IP::InAddrStorage that takes family, or an enum and default constructs correctly? This seems like a repetitive, error prone pattern right now.
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment114520>
I don't know what the style rule is from `(sockaddr_in6*)`, but it's inconsistent with the case above.
- Joris Van Remoortere
On Jan. 26, 2015, 6:56 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2015, 6:56 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review70226
-----------------------------------------------------------
3rdparty/libprocess/include/process/pid.hpp
<https://reviews.apache.org/r/29289/#comment115303>
line is too long. i can fix before commit.
- Dominic Hamon
On Jan. 28, 2015, 2:04 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 2:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review70224
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Jan. 28, 2015, 2:04 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 2:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Feb. 11, 2015, 5:58 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/tests/http_tests.cpp, line 405
> > <https://reviews.apache.org/r/29289/diff/14/?file=860864#file860864line405>
> >
> > add a TODO to test IPv6 HTTP stuff.
added
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review71980
-----------------------------------------------------------
On Feb. 12, 2015, 5:47 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 5:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 426b3faaaed3cb1bd45170ddb77bdf54a1b28ded
> 3rdparty/libprocess/src/http.cpp 7503313312cdcde4027c7dd106a3d7147a948038
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review71980
-----------------------------------------------------------
3rdparty/libprocess/src/tests/http_tests.cpp
<https://reviews.apache.org/r/29289/#comment117895>
add a TODO to test IPv6 HTTP stuff.
- Dominic Hamon
On Feb. 11, 2015, 7:39 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 7:39 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 426b3faaaed3cb1bd45170ddb77bdf54a1b28ded
> 3rdparty/libprocess/src/http.cpp 7503313312cdcde4027c7dd106a3d7147a948038
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review72199
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Feb. 12, 2015, 9:47 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2015, 9:47 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 426b3faaaed3cb1bd45170ddb77bdf54a1b28ded
> 3rdparty/libprocess/src/http.cpp 7503313312cdcde4027c7dd106a3d7147a948038
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Extend the IP and IPNetwork
classes to support IPv6.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74531
-----------------------------------------------------------
3rdparty/libprocess/include/process/pid.hpp
<https://reviews.apache.org/r/29289/#comment121123>
can you define this in terms of the bool () operator?
even better, where are these bool/! operators used? i'm always suspicious when i see them as there's a lot of magic under the hood.
3rdparty/libprocess/src/http.cpp
<https://reviews.apache.org/r/29289/#comment121124>
TODO to add an IPv6 version? or pass in AF_UNSPEC?
- Dominic Hamon
On Feb. 27, 2015, 1:22 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 1:22 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review75351
-----------------------------------------------------------
Bad patch!
Reviews applied: [31677]
Failed command: ./support/apply-review.sh -n -r 31677
Error:
2015-03-05 17:07:20 URL:https://reviews.apache.org/r/31677/diff/raw/ [1337/1337] -> "31677.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp:350
error: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On March 5, 2015, 3:48 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 3:48 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 6f9a0d290de6838c20d208266b670999186e1798
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review75499
-----------------------------------------------------------
Bad patch!
Reviews applied: [31677]
Failed command: ./support/apply-review.sh -n -r 31677
Error:
2015-03-06 18:13:50 URL:https://reviews.apache.org/r/31677/diff/raw/ [1337/1337] -> "31677.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp:350
error: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On March 6, 2015, 5:16 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 5:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On March 6, 2015, 6:38 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/process.cpp, line 837
> > <https://reviews.apache.org/r/29289/diff/24/?file=887418#file887418line837>
> >
> > Please do not remove any logging.
> >
> > ```
> > LOG(FATAL) << "Parsing LIBPROCESS_IP=" << value << " failed: " << ip.error();
> > ```
> >
> > `ip.isError()` is a boolean, are you going to print a boolean when the parsing fails?
sorry for that.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74860
-----------------------------------------------------------
On March 6, 2015, 5:16 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 5:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74860
-----------------------------------------------------------
3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/29289/#comment121664>
Why change this? I thought the original code should just work fine because `hash_combine` will invoke `hash_value` for `IP`.
3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/29289/#comment122608>
Please follow the style guide for includes:
```
#include <boost/functional/hash.hpp>
#include <stout/ip.hpp>
```
3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/29289/#comment122609>
No need to use leading underscore for all parameters! In this case, it's not necessary.
3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/29289/#comment122610>
Let's not add any IPv6 impl. yet in this patch. Please remove them.
3rdparty/libprocess/include/process/network.hpp
<https://reviews.apache.org/r/29289/#comment122638>
Why do you want to pass in the family? Can you get the family from sockaddr_storage?
This changes the Socket API below which we should avoid if uncesssary.
3rdparty/libprocess/include/process/network.hpp
<https://reviews.apache.org/r/29289/#comment122641>
I don't think you need to initialize the sockaddr_storage here? As a result, you don't need to construct an IP.
3rdparty/libprocess/include/process/pid.hpp
<https://reviews.apache.org/r/29289/#comment122611>
Add a blank line above `#include <stout/ip.hpp>`
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment122643>
As I explained above, no need to do this API change!
3rdparty/libprocess/src/pid.cpp
<https://reviews.apache.org/r/29289/#comment122613>
Add a space before `TODO`.
3rdparty/libprocess/src/pid.cpp
<https://reviews.apache.org/r/29289/#comment122626>
As we discussed offline. This change is not necessary. Please revert.
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/29289/#comment122646>
Please do not remove any logging.
```
LOG(FATAL) << "Parsing LIBPROCESS_IP=" << value << " failed: " << ip.error();
```
`ip.isError()` is a boolean, are you going to print a boolean when the parsing fails?
- Jie Yu
On March 6, 2015, 5:16 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 5:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review75622
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 6, 2015, 10:56 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 10:56 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 6, 2015, 10:56 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 6, 2015, 8:07 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 6, 2015, 8:03 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 6, 2015, 5:16 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review75442
-----------------------------------------------------------
Bad patch!
Reviews applied: [31677]
Failed command: ./support/apply-review.sh -n -r 31677
Error:
2015-03-06 01:28:59 URL:https://reviews.apache.org/r/31677/diff/raw/ [1337/1337] -> "31677.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp:350
error: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On March 5, 2015, 7:38 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 7:38 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 5, 2015, 7:38 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Changes
-------
rebased
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 5, 2015, 3:48 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 6f9a0d290de6838c20d208266b670999186e1798
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74947
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31470, 31471, 29288, 31677, 31472, 29290, 31473, 29289]
All tests passed.
- Mesos ReviewBot
On March 3, 2015, 11:26 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 11:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 6f9a0d290de6838c20d208266b670999186e1798
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 3, 2015, 11:26 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Summary (updated)
-----------------
libprocess: Create IP and IPNetwork AF_INET abstraction.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description (updated)
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 6f9a0d290de6838c20d208266b670999186e1798
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Extend the IP and IPNetwork
classes to support IPv6.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74465
-----------------------------------------------------------
Bad patch!
Reviews applied: [29288]
Failed command: ./support/apply-review.sh -n -r 29288
Error:
2015-02-27 09:34:46 URL:https://reviews.apache.org/r/29288/diff/raw/ [17014/17014] -> "29288.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp:86
error: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:74
error: 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp:105
error: 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Feb. 27, 2015, 9:22 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 9:22 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Extend the IP and IPNetwork
classes to support IPv6.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 9:22 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Extend the IP and IPNetwork
classes to support IPv6.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74456
-----------------------------------------------------------
Bad patch!
Reviews applied: [29288]
Failed command: ./support/apply-review.sh -n -r 29288
Error:
2015-02-27 07:38:41 URL:https://reviews.apache.org/r/29288/diff/raw/ [17014/17014] -> "29288.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp:86
error: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:74
error: 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp:105
error: 3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Feb. 27, 2015, 6:52 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 6:52 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Extend the IP and IPNetwork
classes to support IPv6.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 6:52 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Extend the IP and IPNetwork
classes to support IPv6.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Feb. 26, 2015, 6:11 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/network.hpp, line 70
> > <https://reviews.apache.org/r/29289/diff/18/?file=877548#file877548line70>
> >
> > leaking of abstraction here. is there something we can do better? Can you just use sizeof(storage.get())?
used sizeof(sockaddr_storage)
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74304
-----------------------------------------------------------
On Feb. 26, 2015, 6:44 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 6:44 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Extend the IP and IPNetwork
classes to support IPv6.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74304
-----------------------------------------------------------
3rdparty/libprocess/include/process/network.hpp
<https://reviews.apache.org/r/29289/#comment120859>
leaking of abstraction here. is there something we can do better? Can you just use sizeof(storage.get())?
- Dominic Hamon
On Feb. 25, 2015, 10:44 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 10:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Created the inner class InAddrStorage encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Extend the IP and IPNetwork
classes to support IPv6.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 6:44 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Summary (updated)
-----------------
libprocess: Extend the IP and IPNetwork classes to support IPv6.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Feb. 21, 2015, 3:21 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 426b3faaaed3cb1bd45170ddb77bdf54a1b28ded
3rdparty/libprocess/src/http.cpp 7503313312cdcde4027c7dd106a3d7147a948038
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 8:02 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 426b3faaaed3cb1bd45170ddb77bdf54a1b28ded
3rdparty/libprocess/src/http.cpp 7503313312cdcde4027c7dd106a3d7147a948038
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 5:47 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 426b3faaaed3cb1bd45170ddb77bdf54a1b28ded
3rdparty/libprocess/src/http.cpp 7503313312cdcde4027c7dd106a3d7147a948038
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Feb. 11, 2015, 3:39 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Changes
-------
merged InternetAddress with IP
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 426b3faaaed3cb1bd45170ddb77bdf54a1b28ded
3rdparty/libprocess/src/http.cpp 7503313312cdcde4027c7dd106a3d7147a948038
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 6:03 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Changes
-------
split the long line
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 28, 2015, 10:04 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 28, 2015, 9:57 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 27, 2015, 4:58 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 26, 2015, 6:56 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description (updated)
-------
Created the inner class InAddrStorage encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 15, 2015, 7:18 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 8, 2015, 10:55 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review67311
-----------------------------------------------------------
Ship it!
- Dominic Hamon
On Jan. 8, 2015, 7:44 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 7:44 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 8, 2015, 3:44 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 8, 2015, 3:28 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 80578e2207d5436a4414f56417a0fee06ca9a7e9
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review67125
-----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment110958>
this would be simpler if createSockaddrIn was IP agnostic.
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment110959>
iiiiindeeeeent :)
- Dominic Hamon
On Jan. 7, 2015, 10:16 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 10:16 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 7, 2015, 6:16 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review66901
-----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment110597>
I think the part with initializing sockaddr_in can be omitted.
- Evelina Dumitrescu
On Jan. 6, 2015, 2:17 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 2:17 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Jan. 6, 2015, 5:37 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/node.hpp, line 64
> > <https://reviews.apache.org/r/29289/diff/4/?file=807769#file807769line64>
> >
> > why are you adding seed as an argument then immediately overriding it in the body of the function?
That was a mistake, Thanks for that!
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review66865
-----------------------------------------------------------
On Jan. 7, 2015, 6:16 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 6:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
> 3rdparty/libprocess/src/socket.cpp 4b0f6bec8051f938812dbc90a7312e4082ea203f
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Jan. 6, 2015, 5:37 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 49
> > <https://reviews.apache.org/r/29289/diff/4/?file=807771#file807771line49>
> >
> > the API is more complex here, which seems like a regression. Is it possible to simplify this?
> >
> > sockaddr_in addr = net::createSockaddrIn(net::IP::Address(), 0);
> >
> > ?
> >
> > though I suppose actually the accept call should be wrapped up now and use the Address abstraction, so maybe this is a temporary change?
the part with initializing sockaddr_in can be omitted.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review66865
-----------------------------------------------------------
On Jan. 6, 2015, 2:17 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 2:17 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Jan. 6, 2015, 5:37 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/socket.hpp, line 45
> > <https://reviews.apache.org/r/29289/diff/4/?file=807771#file807771line45>
> >
> > why change the type of family?
The majority of socket calls uses the int type.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review66865
-----------------------------------------------------------
On Jan. 6, 2015, 2:17 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 2:17 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review66865
-----------------------------------------------------------
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/29289/#comment110543>
why are you adding seed as an argument then immediately overriding it in the body of the function?
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment110545>
why change the type of family?
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment110544>
the API is more complex here, which seems like a regression. Is it possible to simplify this?
sockaddr_in addr = net::createSockaddrIn(net::IP::Address(), 0);
?
though I suppose actually the accept call should be wrapped up now and use the Address abstraction, so maybe this is a temporary change?
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment110546>
better TODO: add a bind wrapper at the lower layer to abstcract this away completely.
- Dominic Hamon
On Jan. 6, 2015, 6:17 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 6:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created the inner class Address encapsulated inside the IP class.
> The class uses a union with the in_addr and in6_addr fields.
> I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
> I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
> 3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
> 3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 2:17 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 1:09 p.m.)
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 5:51 a.m.)
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp ddb9e365fc1e65a568bdac4973964df1ab8cc05e
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 67b6b3b9c13d95fa1a24b48a12c5c831c7f249bf
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Dec. 30, 2014, 5:21 a.m.)
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description (updated)
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs (updated)
-----
src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3
src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74
src/linux/routing/diagnosis/diagnosis.cpp 136ba379efbbe4200c0e9f794a2966ffee174fff
src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d
src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2
src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d
src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8
src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd
src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
src/slave/containerizer/isolators/network/port_mapping.cpp 2d813369bd844ad743f7d3f18dbab29b2467f2c8
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/master_contender_detector_tests.cpp d847a30d21b2a2980c6b7ceb62bbf61dc77487de
src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894
src/tests/port_mapping_tests.cpp eb82993520f7e8de46cf6cf6b638a9286aa9b3df
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Created IP address abstraction
for different protocol families
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated Dec. 20, 2014, 3:38 a.m.)
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Created the inner class Address encapsulated inside the IP class.
The class uses a union with the in_addr and in6_addr fields.
The Address can be in NETWORK or BYTE order.
I considered that the The MasterInfo protobuffers should have both an ipv4 and an ipv6 field.
I intend to use the same Classifiers, addition, removal and update of container filters, but write different encode/decode functions for IPv4/ICMP and IPv6/ICMPv6 because the processing of the protocol headers differ.
Diffs
-----
3rdparty/libprocess/include/process/node.hpp 173eb8abe0d0930c92f261be7a95e07b1d4c16af
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/include/process/socket.hpp 7e1e3f22583f44a9aea8259bafedc2877ad2e633
3rdparty/libprocess/src/pid.cpp 085e0b9abe9a9f33a63247915835decbf942274d
3rdparty/libprocess/src/process.cpp 028b33e7ecb7e0a39334ac4ab0279ee327a72a56
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu