[GitHub] [incubator-druid] mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization

[GitBox <gi...@apache.org>]

mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization
URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r322789018
 
 

 ##########
 File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/db/cache/CoordinatorBasicAuthenticatorCacheNotifier.java
 ##########
 @@ -42,9 +42,9 @@
 @ManageLifecycle
 public class CoordinatorBasicAuthenticatorCacheNotifier implements BasicAuthenticatorCacheNotifier
 {
-
   private final LifecycleLock lifecycleLock = new LifecycleLock();
-  private CommonCacheNotifier cacheNotifier;
+  private final CommonCacheNotifier userCacheNotifier;
+  private final CommonCacheNotifier configCacheNotifier;
 
 Review comment:
   Good catch, no it's not used anymore. i'll remove it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org