You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/02 17:22:15 UTC

[GitHub] [airflow] aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers

aoen commented on a change in pull request #6709: [AIRFLOW-5834] Option to skip serve_logs process with workers
URL: https://github.com/apache/airflow/pull/6709#discussion_r352723411
 
 

 ##########
 File path: airflow/cli/commands/worker_command.py
 ##########
 @@ -76,17 +85,19 @@ def worker(args):
             stderr=stderr,
         )
         with ctx:
-            sub_proc = subprocess.Popen(['airflow', 'serve_logs'], env=env, close_fds=True)
+            if skip_serve_logs is False:
 
 Review comment:
   Nit: Let's factor this out into a private function _serve_logs() to dedup (I know the previous logic didn't have it but we are slightly increasing complexity with this change anyways so I think we should fix this).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services