[GitHub] [incubator-iceberg] rdblue opened a new pull request #654: Move identifier validation into BaseMetastoreCatalog

[GitBox <gi...@apache.org>]

rdblue opened a new pull request #654: Move identifier validation into BaseMetastoreCatalog
URL: https://github.com/apache/incubator-iceberg/pull/654
 
 
   For catalogs that extend `BaseMetastoreCatalog`, identifier validation is difficult to implement. Identifiers should be validated before they are passed to `newTableOps` because validation in `newTableOps` doesn't have enough information to throw the correct exception: from `createTable` it should throw a `ValidationException` but from `loadTable` it should throw `NoSuchTableException`.
   
   It is also difficult to ensure that metadata tables work with identifier validation because metadata tables rely on a valid identifier but may not be a valid identifier themselves. For example, Hive tables require 1 level of namespacing, but metadata tables use the full valid table identifier as a namespace.
   
   This moves validation to a method that can be overridden and fixes some of these difficult cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org