You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/07/10 16:39:58 UTC
[GitHub] [maven-reporting-exec] cstamas opened a new pull request, #14: Update module:
cstamas opened a new pull request, #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14
* drop m-shared-utils (was used only for StringUtils!!!)
* drop plexus container default and plexus annotations, migrate to JSR330
* set plexus-classworld scope proper, IS USED in main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] cstamas commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1190598805
@michael-o pls take over this PR, as I don't think will have time to finish it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] asfgit closed pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #14: Update module:
URL: https://github.com/apache/maven-reporting-exec/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] hboutemy commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
hboutemy commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1189472714
from https://issues.apache.org/jira/browse/MSHARED-921 , what is important is to check with older Maven versions ( < 3.6.1 ): @michael-o did you try with Maven 3.3.9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on a diff in pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#discussion_r917427030
##########
pom.xml:
##########
@@ -77,46 +77,42 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-settings</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-settings-builder</artifactId>
<version>${mavenVersion}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.maven.shared</groupId>
- <artifactId>maven-shared-utils</artifactId>
- <version>3.3.4</version>
- </dependency>
- <dependency>
- <groupId>org.codehaus.plexus</groupId>
- <artifactId>plexus-component-annotations</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
- <version>3.1.0</version><!-- do not upgrade to 3.2.0+ because it adds Xpp3Dom.getInputLocation(): see MSHARED-921 -->
+ <version>3.4.2</version>
</dependency>
Review Comment:
Then you also need to remove the shading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on a diff in pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#discussion_r917426531
##########
pom.xml:
##########
@@ -188,11 +190,11 @@
<scope>test</scope>
</dependency>
- <!-- Used actually in tests only, but if in test scope the transitive dep will be gone -->
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-classworlds</artifactId>
- <version>2.5.2</version>
+ <version>2.6.0</version>
+ <scope>compile</scope>
Review Comment:
Do we really need this in compile?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] hboutemy commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
hboutemy commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1190556948
I really don't understand why Xpp3DomUtils.mergeXpp3Dom call works now with older Maven 3.3.9 without the shade trick https://github.com/apache/maven-reporting-exec/blob/master/src/main/java/org/apache/maven/reporting/exec/DefaultMavenReportExecutor.java#L514
but it seems to just work now... (if anybody can understand, please help :) )
ok for me to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on a diff in pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#discussion_r922721145
##########
pom.xml:
##########
@@ -77,46 +77,42 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-settings</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-settings-builder</artifactId>
<version>${mavenVersion}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.maven.shared</groupId>
- <artifactId>maven-shared-utils</artifactId>
- <version>3.3.4</version>
- </dependency>
- <dependency>
- <groupId>org.codehaus.plexus</groupId>
- <artifactId>plexus-component-annotations</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
- <version>3.1.0</version><!-- do not upgrade to 3.2.0+ because it adds Xpp3Dom.getInputLocation(): see MSHARED-921 -->
+ <version>3.4.2</version>
</dependency>
Review Comment:
@hboutemy WDYT? For me, all MSITE ITs are working. I am fine with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1189522125
I installed exec from this branch. Modified MSITE to use this SNAPSHOT, used Maven 3.3.9 to install and run ITs. Works. Used Doxia 2 branches on MPIR and MPLUGIN, updated MSITE to M3-SNAPSHOT, again with 3.3.9 install and ITs. Works.
@hboutemy Is that sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1190558797
> I really don't understand why Xpp3DomUtils.mergeXpp3Dom call works now with older Maven 3.3.9 without the shade trick https://github.com/apache/maven-reporting-exec/blob/master/src/main/java/org/apache/maven/reporting/exec/DefaultMavenReportExecutor.java#L514
>
> but it seems to just work now... (if anybody can understand, please help :) )
>
> ok for me to merge
Yepp, this is what I am trying to understand as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1190591474
@cstamas I'd still insist on dropping `provided` for this milestone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] hboutemy commented on a diff in pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
hboutemy commented on code in PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#discussion_r924887516
##########
pom.xml:
##########
@@ -77,46 +77,42 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-settings</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-settings-builder</artifactId>
<version>${mavenVersion}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.maven.shared</groupId>
- <artifactId>maven-shared-utils</artifactId>
- <version>3.3.4</version>
- </dependency>
- <dependency>
- <groupId>org.codehaus.plexus</groupId>
- <artifactId>plexus-component-annotations</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
- <version>3.1.0</version><!-- do not upgrade to 3.2.0+ because it adds Xpp3Dom.getInputLocation(): see MSHARED-921 -->
+ <version>3.4.2</version>
</dependency>
Review Comment:
from https://issues.apache.org/jira/browse/MSHARED-921 , what is important is to check with older Maven versions ( < 3.6.1 ): @michael-o did you try with Maven 3.3.9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1189494239
@hboutemy Testing again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1190576007
@hboutemy So I assume we have your consent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on a diff in pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#discussion_r917426502
##########
pom.xml:
##########
@@ -77,46 +77,42 @@
<groupId>org.apache.maven</groupId>
<artifactId>maven-artifact</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-model</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-plugin-api</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-settings</artifactId>
<version>${mavenVersion}</version>
+ <scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-settings-builder</artifactId>
<version>${mavenVersion}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.maven.shared</groupId>
- <artifactId>maven-shared-utils</artifactId>
- <version>3.3.4</version>
- </dependency>
- <dependency>
- <groupId>org.codehaus.plexus</groupId>
- <artifactId>plexus-component-annotations</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
- <version>3.1.0</version><!-- do not upgrade to 3.2.0+ because it adds Xpp3Dom.getInputLocation(): see MSHARED-921 -->
+ <version>3.4.2</version>
</dependency>
Review Comment:
I'd like to have Hervé's consent on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1189475534
> from https://issues.apache.org/jira/browse/MSHARED-921 , what is important is to check with older Maven versions ( < 3.6.1 ): @michael-o did you try with Maven 3.3.9?
I actually did, but want to double-check. exec is used in reporting plugins only, means no maven-site-plugin, direct invocation. Therefore, I'd would be good enough to run a few of them with this change and when they work then this is fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1190369280
> I need to check Git history to understand
>
> > exec is used in reporting plugins only, means no maven-site-plugin, direct invocation.
>
> no, exec is used in m-site-p and m-pdf-p, to run reports
You are totally right. My statement is wrong. I messed it up with `-impl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] michael-o commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1190615427
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] asfgit merged pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] cstamas commented on a diff in pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#discussion_r917428563
##########
pom.xml:
##########
@@ -188,11 +190,11 @@
<scope>test</scope>
</dependency>
- <!-- Used actually in tests only, but if in test scope the transitive dep will be gone -->
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-classworlds</artifactId>
- <version>2.5.2</version>
+ <version>2.6.0</version>
+ <scope>compile</scope>
Review Comment:
Comment is totally wrong, and it WAS in compile scope already, I just made it obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-reporting-exec] hboutemy commented on pull request #14: Update module:
Posted by GitBox <gi...@apache.org>.
hboutemy commented on PR #14:
URL: https://github.com/apache/maven-reporting-exec/pull/14#issuecomment-1190361201
I need to check Git history to understand
> exec is used in reporting plugins only, means no maven-site-plugin, direct invocation.
no, exec is used in m-site-p and m-pdf-p, to run reports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org