[GitHub] [geode] jvarenina commented on a change in pull request #6036: GEODE-8856: Persist gateway-sender state

[GitBox <gi...@apache.org>]

jvarenina commented on a change in pull request #6036:
URL: https://github.com/apache/geode/pull/6036#discussion_r605594756



##########
File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/functions/GatewaySenderFunctionArgs.java
##########
@@ -47,6 +47,7 @@
   private final List<String> gatewayEventFilters;
   private final List<String> gatewayTransportFilters;
   private final Boolean enforceThreadsConnectSameReceiver;
+  private final String state;

Review comment:
       Thank you for the comment!
   
   Currently, `CreateGatewaySenderCommand` can only manipulate with the initial state of gateway-sender by using deprecated `--manual-start` parameter (default value is false). This parameter does not update the new `state` parameter.
   
   As you suggested, we could also add `--state` parameter in `create gateway-sender`. We could maybe then completely remove the depreciated `--manual-start` parameter, since `--state` will do the same thing (and even more considering "paused" state) as `--manual-start` parameter. As it is now, these two parameters have functional conflict which is currently resolved as described in RFC under "Solution" chapter: https://cwiki.apache.org/confluence/display/GEODE/Persist+gateway-sender+state+within+Cluster+Configuration?moved=true
   
   What do you think? Do you see benefit in having --state parameter in create gateway-sender command?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org