[GitHub] [skywalking] wu-sheng commented on a change in pull request #4878: Refactory spring gateway plugin

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4878:
URL: https://github.com/apache/skywalking/pull/4878#discussion_r438766716



##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/tag/Tags.java
##########
@@ -78,7 +78,7 @@ private Tags() {
     public static final StringTag MQ_TOPIC = new StringTag(9, "mq.topic");
 
     public static final class HTTP {
-        public static final StringTag METHOD = new StringTag(10, "http.method");
+        public static final StringTag METHOD = new StringTag(10, "http.method", true);

Review comment:
       Please don't open this as overridable. It costs too much.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org