You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by radarwave <gi...@git.apache.org> on 2015/11/14 04:28:07 UTC
[GitHub] incubator-hawq pull request: HAWQ-158. Remove legacy command line ...
GitHub user radarwave opened a pull request:
https://github.com/apache/incubator-hawq/pull/112
HAWQ-158. Remove legacy command line tools and help.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radarwave/incubator-hawq hawq158
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #112
----
commit 5ac4262384de92a550811798956d3e24d1740a29
Author: rlei <rl...@pivotal.io>
Date: 2015-11-14T03:18:41Z
HAWQ-158. Remove legacy command line tools and help.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-158. Remove legacy command line ...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave closed the pull request at:
https://github.com/apache/incubator-hawq/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-158. Remove legacy command line ...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/112#discussion_r44856119
--- Diff: tools/Makefile ---
@@ -38,13 +38,7 @@ SET_VERSION_SCRIPTS = \
bin/gpssh-exkeys \
--- End diff --
gpssh-exkeys still in use. 'hawq ssh' will call it.
For others not in bin or sbin, there still plenty need to be remove, we will review and remove them in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-158. Remove legacy command line ...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/112#issuecomment-156659741
The overall fix is good. +1
Why we have gpssh-exkeys and clsAddMirrors.py in Makefile as they are deprecated?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-158. Remove legacy command line ...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/112#discussion_r44856018
--- Diff: tools/Makefile ---
@@ -38,13 +38,7 @@ SET_VERSION_SCRIPTS = \
bin/gpssh-exkeys \
--- End diff --
Why not remove gpssh-exkeys as we have hawq ssh now?
Why not remove clsAddMirrors.py as we don't have mirrors in hawq?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---