You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/15 20:10:45 UTC

[GitHub] eolivelli commented on a change in pull request #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value

eolivelli commented on a change in pull request #1252: Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value
URL: https://github.com/apache/bookkeeper/pull/1252#discussion_r174916473
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java
 ##########
 @@ -741,7 +741,8 @@ ZooKeeper getZkHandle() {
         return ((ZKMetadataClientDriver) metadataDriver).getZk();
     }
 
-    protected ClientConfiguration getConf() {
+    @VisibleForTesting
+    public ClientConfiguration getConf() {
 
 Review comment:
   This is not good.
   Unfortunately this object is mutable.
   You can you Whitebox in tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services