You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/05/23 15:05:15 UTC

[GitHub] [geode] DonalEvans commented on a diff in pull request #7716: GEODE-10328: close data store stats on cache close

DonalEvans commented on code in PR #7716:
URL: https://github.com/apache/geode/pull/7716#discussion_r879565795


##########
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java:
##########
@@ -7767,6 +7768,16 @@ protected void postDestroyRegion(boolean destroyDiskRegion, RegionEventImpl even
         cache.getInternalDistributedSystem().getDistributedMember(), null, op.isClose());
   }
 
+  private void closeDataStoreStats() {
+    PartitionedRegionDataStore localDataStore = dataStore;

Review Comment:
   Is this local variable necessary? Could we just use `dataStore` directly in this method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org