You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/12/03 02:10:15 UTC
[kudu-CR] [thirdparty] skip building trace tools for RocksDB
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19316
Change subject: [thirdparty] skip building trace tools for RocksDB
......................................................................
[thirdparty] skip building trace tools for RocksDB
This patch updates the list of components to build for RocksDB. In
particular, trace tools are no longer built. It also fixes a misprint
in specifying whether to build dynamic library.
This is a follow-up to fab4c6fd30dc4bdfb52e854584e9433ef6c1f363.
Change-Id: Idcc23ffe188d8bcc10e10cb3ca344f4f4bba8b9e
---
M thirdparty/build-definitions.sh
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/19316/1
--
To view, visit http://gerrit.cloudera.org:8080/19316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcc23ffe188d8bcc10e10cb3ca344f4f4bba8b9e
Gerrit-Change-Number: 19316
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [thirdparty] skip building trace tools for RocksDB
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19316 )
Change subject: [thirdparty] skip building trace tools for RocksDB
......................................................................
[thirdparty] skip building trace tools for RocksDB
This patch updates the list of components to build for RocksDB. In
particular, trace tools are no longer built. It also fixes a misprint
in specifying whether to build dynamic library.
This is a follow-up to fab4c6fd30dc4bdfb52e854584e9433ef6c1f363.
Change-Id: Idcc23ffe188d8bcc10e10cb3ca344f4f4bba8b9e
Reviewed-on: http://gerrit.cloudera.org:8080/19316
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Tested-by: Kudu Jenkins
---
M thirdparty/build-definitions.sh
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idcc23ffe188d8bcc10e10cb3ca344f4f4bba8b9e
Gerrit-Change-Number: 19316
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [thirdparty] skip building trace tools for RocksDB
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19316 )
Change subject: [thirdparty] skip building trace tools for RocksDB
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19316
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcc23ffe188d8bcc10e10cb3ca344f4f4bba8b9e
Gerrit-Change-Number: 19316
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 03 Dec 2022 02:14:50 +0000
Gerrit-HasComments: No