You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2015/06/04 07:04:39 UTC

[jira] [Commented] (MNG-5818) Disallow plugins from programmatically adding dependencies to projects

    [ https://issues.apache.org/jira/browse/MNG-5818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572147#comment-14572147 ] 

Hudson commented on MNG-5818:
-----------------------------

SUCCESS: Integrated in maven-3.x #1081 (See [https://builds.apache.org/job/maven-3.x/1081/])
MNG-5818: Disallow the programmatic injection of project dependencies (jason: rev 4567c8319e95d58e258e9a8c2067ed9bbe01b58e)
* maven-core/src/main/java/org/apache/maven/project/MavenProject.java


> Disallow plugins from programmatically adding dependencies to projects
> ----------------------------------------------------------------------
>
>                 Key: MNG-5818
>                 URL: https://issues.apache.org/jira/browse/MNG-5818
>             Project: Maven
>          Issue Type: Task
>            Reporter: Jason van Zyl
>            Assignee: Jason van Zyl
>
> MavenProject.setDependencyArtifacts(deps) is publicly available to plugins that can alter the classpath non-declaratively. For compatibility reasons in MNG-4363 we restored this capability for the cobertura-maven-plugin but it needs to be removed. It causes some nasty logic in the core, but it being non-delclarative and magical is the real problem.
> We need to deprecate MavenProject.setDependencyArtifacts(deps), and replace the logic for constructing the artifacts in a better. Preferably passing in the artifacts in the constructor of MavenProject.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)