You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2012/08/13 23:56:38 UTC
[jira] [Commented] (HDFS-2330) In NNStorage.java, IOExceptions of
stream closures can mask root exceptions.
[ https://issues.apache.org/jira/browse/HDFS-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433613#comment-13433613 ]
Hudson commented on HDFS-2330:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2639 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2639/])
Move HDFS-2330 and HDFS-3190 to branch-2 section, since they have been backported from trunk. (Revision 1372605)
Result = SUCCESS
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1372605
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> In NNStorage.java, IOExceptions of stream closures can mask root exceptions.
> -----------------------------------------------------------------------------
>
> Key: HDFS-2330
> URL: https://issues.apache.org/jira/browse/HDFS-2330
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 3.0.0, 2.2.0-alpha
>
> Attachments: HDFS-2330.patch, HDFS-2330.patch
>
>
> In NNStorage.java:
> There are many stream closures in finally block.
> There is a chance that they can mask the root exceptions.
> So, better to follow the pattern like below:
> {code}
> try{
> ............
> ............
> stream.close();
> stream =null;
> }
> finally{
> IOUtils.cleanup(LOG, stream);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira