You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/12/17 09:14:27 UTC

[GitHub] [bookkeeper] Radiancebobo commented on pull request #3706: [improvement] checkNotNull when use computeIfAbsent in ConcurrentLongHashMap and ConcurrentOpenHashMap

Radiancebobo commented on PR #3706:
URL: https://github.com/apache/bookkeeper/pull/3706#issuecomment-1356135207

   If we allow valueProvider.apply(key) to return null, we also need to avoid leaks, maybe change it like this:
   ![image](https://user-images.githubusercontent.com/39521534/208234805-8239f616-3d38-4936-beac-ebccc555401f.png)
   so.
   ![image](https://user-images.githubusercontent.com/39521534/208234831-c0857163-2e47-458d-9243-9b1fc04c7175.png)
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org