You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/02/22 19:28:26 UTC
[GitHub] [systemds] clarapueyoballarin opened a new pull request #1188: Denial Constrains
clarapueyoballarin opened a new pull request #1188:
URL: https://github.com/apache/systemds/pull/1188
Added new .dml script for denial constrains calculation
Added its implementation for the builtins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Shafaq-Siddiqi closed pull request #1188: [WIP] Denial Constraints
Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi closed pull request #1188:
URL: https://github.com/apache/systemds/pull/1188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Shafaq-Siddiqi commented on a change in pull request #1188: Denial Constrains
Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi commented on a change in pull request #1188:
URL: https://github.com/apache/systemds/pull/1188#discussion_r581787107
##########
File path: src/main/java/org/apache/sysds/common/Builtins.java
##########
@@ -99,6 +99,7 @@
COR("cor", true),
DBSCAN("dbscan", true),
DETECTSCHEMA("detectSchema", false),
+ DENIALCONSTRAINS("denialConstrains", false),
Review comment:
change the values of the script parameter to true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Shafaq-Siddiqi commented on pull request #1188: Denial Constrains
Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi commented on pull request #1188:
URL: https://github.com/apache/systemds/pull/1188#issuecomment-784931941
Hi,
Thank you for your contribution. Please add the tests in our test suite for your built-in. For the DML scripts, we use two-space indentation. If you are still working on the project please mark it as "WIP".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Shafaq-Siddiqi commented on pull request #1188: Denial Constraints
Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi commented on pull request #1188:
URL: https://github.com/apache/systemds/pull/1188#issuecomment-797434502
LGTM,
Thank you @clarapueyoballarin for your contribution. During the merge, I have fixed some minor formatting, warnings, and header of the DML script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org