[GitHub] [iceberg] rdblue commented on a change in pull request #2081: Allow binary truncation length to be zero to handle evaluators that encounter empty string values

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2081:
URL: https://github.com/apache/iceberg/pull/2081#discussion_r558581834



##########
File path: spark3/src/test/java/org/apache/iceberg/spark/source/TestFilteredScan.java
##########
@@ -529,7 +529,7 @@ private Table buildPartitionedTable(String desc, PartitionSpec spec, String udf,
     return Lists.newArrayList(
         record(schema, 0L, parse("2017-12-22T09:20:44.294658+00:00"), "junction"),
         record(schema, 1L, parse("2017-12-22T07:15:34.582910+00:00"), "alligator"),
-        record(schema, 2L, parse("2017-12-22T06:02:09.243857+00:00"), "forrest"),
+        record(schema, 2L, parse("2017-12-22T06:02:09.243857+00:00"), ""),

Review comment:
       I'm fine adding the test here, but I'd rather not change the existing cases. Would adding a new record test this without affecting the existing ones?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org