You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by cluo512 <gi...@git.apache.org> on 2017/07/31 06:25:32 UTC
[GitHub] storm pull request #2247: Force to make some files in final-package use unix...
GitHub user cluo512 opened a pull request:
https://github.com/apache/storm/pull/2247
Force to make some files in final-package use unix line ending
I made a distribution from source code on windows OS, but when I want to launch this on linux. I found there are some mistake for line break in the scripts. And then I found the settings for line ending in the binary.xml was not set obviously, so it is decided by the OS where run the maven command.
I think its better to set the line ending obviously for unix. because we mostly use linux system to deploy storm and, at the same time, this distribution will run well in the windows OS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cluo512/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2247.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2247
----
commit 63a3ed588f3f597e8c6f186305bfce4ccf7d5387
Author: cluo <05...@163.com>
Date: 2017-07-31T06:08:05Z
Force to make the final-package some files use unix line ending
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2247: STORM-2664: Fix for the distribution packaged on W...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...
Posted by cluo512 <gi...@git.apache.org>.
Github user cluo512 commented on the issue:
https://github.com/apache/storm/pull/2247
@srdo The issue number have added.
Thanks for your advice again. I'm new about how to contribute.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2247: Force to make some files in final-package use unix line e...
Posted by cluo512 <gi...@git.apache.org>.
Github user cluo512 commented on the issue:
https://github.com/apache/storm/pull/2247
Hi Srdo.
Thank you for your advice.
I create a issue on [https://issues.apache.org/jira/browse/STORM-2664]. And I will rename this PR later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...
Posted by cluo512 <gi...@git.apache.org>.
Github user cluo512 commented on the issue:
https://github.com/apache/storm/pull/2247
Ok..Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...
Posted by cluo512 <gi...@git.apache.org>.
Github user cluo512 commented on the issue:
https://github.com/apache/storm/pull/2247
Oh..check failed.
I looked the details. It seems that @HeartSaVioR changed the CHANGELOG.md to DEVELOPER.md, so maven can't found this file.
Should I update the binary.xml to DEVELOPER.md?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2247
@cluo512 No worries. I'll handle it on merge phase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2247: Force to make some files in final-package use unix line e...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2247
Hi Cluo.
This looks good. I checked, and there doesn't seem to be an issue running the powershell files with LF EOL, so I don't think there's a reason to keep them as CRLF.
Could you open an issue on https://issues.apache.org/jira and rename this PR and commit so it references the JIRA number? See for example https://github.com/apache/storm/pull/2248/commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2247: STORM-2664: Force to make some files in final-package use...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2247
@cluo512 Could you add the issue number to the commit message? Then I think we're good to merge :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2247
@cluo512
Sorry we decided to get rid of CHANGELOG.md, but I forgot to remove it from distribution pom as well. I'll do the update and let you know. You can rebase after then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...
Posted by cluo512 <gi...@git.apache.org>.
Github user cluo512 commented on the issue:
https://github.com/apache/storm/pull/2247
@HeartSaVioR Get it, thanks.
I updated the code for my fork project just now.
but it seems that I do a merge not a rebase. Dose it matter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2247
@cluo512 Done. Please rebase against master. Thanks in advance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2247: STORM-2664: Fix for the distribution packaged on Windows ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2247
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---