You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2012/08/20 00:19:57 UTC

[Bug 53741] New: Code clean up (Concat string at compile time when possible)

https://issues.apache.org/bugzilla/show_bug.cgi?id=53741

          Priority: P2
            Bug ID: 53741
          Assignee: bugs@httpd.apache.org
           Summary: Code clean up (Concat string at compile time when
                    possible)
          Severity: minor
    Classification: Unclassified
                OS: All
          Reporter: christophe.jaillet@wanadoo.fr
          Hardware: All
            Status: NEW
           Version: 2.5-HEAD
         Component: All
           Product: Apache httpd-2

Created attachment 29253
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29253&action=edit
Proposed patch

Hi,

All is said in the title.
It is sometimes possibles to concat strings at compile time as already widely
done in the source code.

Doing so, sometimes also give the opportunity to turn a 'ap_fputstrs' into a
'ap_fputs'


 modules/arch/netware/mod_nw_ssl.c  |    4 ++--
 modules/cache/mod_cache_disk.c     |    4 ++--
 modules/cache/mod_disk_cache.c     |    4 ++--
 modules/http/http_filters.c        |    6 +++---
 modules/mappers/mod_dir.c          |    2 +-
 modules/proxy/mod_proxy_balancer.c |    2 +-
 modules/ssl/ssl_engine_kernel.c    |    4 ++--
 server/protocol.c                  |    2 +-
 support/ab.c                       |    2 +-
 9 files changed, 15 insertions(+), 15 deletions(-)


Best regards

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 53741] Code clean up (Concat string at compile time when possible)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53741

Christophe JAILLET <ch...@wanadoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29253|0                           |1
           is patch|                            |
  Attachment #29253|application/octet-stream    |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 53741] Code clean up (Concat string at compile time when possible)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53741

--- Comment #1 from Yann Ylavic <yl...@gmail.com> ---
Backported to 2.4.11 in r1634525.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 53741] Code clean up (Concat string at compile time when possible)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53741

Christophe JAILLET <ch...@wanadoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 53741] Code clean up (Concat string at compile time when possible)

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53741

Christophe JAILLET <ch...@wanadoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |FixedInTrunk
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org