[GitHub] [pdfbox] larrylynn-wf commented on a change in pull request #117: PDFBOX-5191 | isEmbeddingPermitted() is too restrictive on TTFs with OS2 table version

[GitBox <gi...@apache.org>]

larrylynn-wf commented on a change in pull request #117:
URL: https://github.com/apache/pdfbox/pull/117#discussion_r631346775



##########
File path: pdfbox/pom.xml
##########
@@ -75,6 +75,12 @@
             <artifactId>jbig2-imageio</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.mockito</groupId>
+            <artifactId>mockito-core</artifactId>

Review comment:
       I didn't see any existing tests using a mocking library.  I'm not sure if this is intentional.  I'm also not sure if pdfbox maintainers have a policy against adding new dependencies.  If mockito is undesirable for some reason, I'll have to come up with a different way to test my proposed code change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org