You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/07 14:09:09 UTC
[GitHub] [cloudstack] ravening opened a new pull request #5753: server: Fix NPE while deleting a domain
ravening opened a new pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753
### Description
While deleting a domain, if vlan ip range cant be found
then this will throw NPE. Just return false if vlan ip
range cant be found
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
```
VLAN information for Account 'Acct[ef5d57e5-4b9d-11e3-8346-2c44fd7a3378-system]', User '1' VLAN '843' is null. This is NPE situation.
Exception deleting domain with id 562
java.lang.NullPointerException
at com.cloud.configuration.ConfigurationManagerImpl.releasePublicIpRange(ConfigurationManagerImpl.java:4660)
at com.cloud.configuration.ConfigurationManagerImpl$14.doInTransactionWithoutResult(ConfigurationManagerImpl.java:6386)
```
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1000225497
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 2000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1000257245
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#discussion_r764756527
##########
File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4923,6 +4923,7 @@ public boolean releasePublicIpRange(final long vlanDbId, final long userId, fina
VlanVO vlan = _vlanDao.findById(vlanDbId);
if(vlan == null) {
s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null. This is NPE situation.");
+ return false;
Review comment:
@weizhouapache return true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-989608114
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#discussion_r768328143
##########
File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4922,7 +4922,9 @@ public boolean releasePublicIpRange(final ReleasePublicIpRangeCmd cmd) {
public boolean releasePublicIpRange(final long vlanDbId, final long userId, final Account caller) {
VlanVO vlan = _vlanDao.findById(vlanDbId);
if(vlan == null) {
- s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null. This is NPE situation.");
+ // Nothing to do if vlan can't be found
+ s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null.");
+ return true;
Review comment:
@ravening can you address this ^^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-988709553
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1001434612
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#discussion_r764630129
##########
File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4923,6 +4923,7 @@ public boolean releasePublicIpRange(final long vlanDbId, final long userId, fina
VlanVO vlan = _vlanDao.findById(vlanDbId);
if(vlan == null) {
s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null. This is NPE situation.");
+ return false;
Review comment:
@ravening
return true or false ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-989608503
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-988708908
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1000869202
<b>Trillian test result (tid-2736)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33853 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5753-t2736-kvm-centos7.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_ssvm_internals | `Failure` | 14.08 | test_ssvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#discussion_r770512502
##########
File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4922,7 +4922,9 @@ public boolean releasePublicIpRange(final ReleasePublicIpRangeCmd cmd) {
public boolean releasePublicIpRange(final long vlanDbId, final long userId, final Account caller) {
VlanVO vlan = _vlanDao.findById(vlanDbId);
if(vlan == null) {
- s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null. This is NPE situation.");
+ // Nothing to do if vlan can't be found
+ s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null.");
+ return true;
Review comment:
@DaanHoogland yes, what @GabrielBrascher says is correct.. since vlan cant be found in db, just return true rather than proceeding further.. i will make the required changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-990031232
<b>Trillian test result (tid-2643)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29973 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5753-t2643-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-988738558
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#discussion_r773087591
##########
File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4922,7 +4922,9 @@ public boolean releasePublicIpRange(final ReleasePublicIpRangeCmd cmd) {
public boolean releasePublicIpRange(final long vlanDbId, final long userId, final Account caller) {
VlanVO vlan = _vlanDao.findById(vlanDbId);
if(vlan == null) {
- s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null. This is NPE situation.");
+ // Nothing to do if vlan can't be found
+ s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null.");
+ return true;
Review comment:
Hi @ravening Can you address the required changes as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1000257906
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1000305523
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1000660275
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1000171876
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-988503718
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#discussion_r766766745
##########
File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4922,7 +4922,9 @@ public boolean releasePublicIpRange(final ReleasePublicIpRangeCmd cmd) {
public boolean releasePublicIpRange(final long vlanDbId, final long userId, final Account caller) {
VlanVO vlan = _vlanDao.findById(vlanDbId);
if(vlan == null) {
- s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null. This is NPE situation.");
+ // Nothing to do if vlan can't be found
+ s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null.");
+ return true;
Review comment:
@DaanHoogland I see your [comment](https://github.com/apache/cloudstack/pull/5753#issuecomment-990648272).
> @ravening code looks good but in the diff I don't see the NPE being prevented, does it make sense to have a (unit-)test for this?
I think that the null pointer is avoided by returning `true` in case VLAN is null, instead of proceeding with the `releasePublicUpRange` method. So it looks good at this point.
I would recommend something such as `Skipping the process for releasing public IP range as could not find a VLAN with ID '843' for Account 'Acct[ef5d57e5-4b9d-11e3-8346-2c44fd7a3378-system]' and User '1'.`.
```
s_logger.warn(String.format("Skipping the process for releasing public IP range as could not find a VLAN with ID '%s' for Account '%s' and User '%s'.",vlanDbId, caller, userId));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1000171599
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#discussion_r774402821
##########
File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4922,7 +4922,9 @@ public boolean releasePublicIpRange(final ReleasePublicIpRangeCmd cmd) {
public boolean releasePublicIpRange(final long vlanDbId, final long userId, final Account caller) {
VlanVO vlan = _vlanDao.findById(vlanDbId);
if(vlan == null) {
- s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null. This is NPE situation.");
+ // Nothing to do if vlan can't be found
+ s_logger.warn("VLAN information for Account '" + caller + "', User '" + userId + "' VLAN '" + vlanDbId + "' is null.");
+ return true;
Review comment:
@sureshanaparti made the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1001672370
<b>Trillian test result (tid-2739)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31126 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5753-t2739-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1001434024
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-1000660400
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-988503902
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5753: server: Fix NPE while deleting a domain
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5753:
URL: https://github.com/apache/cloudstack/pull/5753#issuecomment-988543273
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org