You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "BruceWong96 (via GitHub)" <gi...@apache.org> on 2024/08/13 07:24:24 UTC
[PR] [KYUUBI #6593][Improvement] Support bin/kyuubi kill command [kyuubi]
BruceWong96 opened a new pull request, #6611:
URL: https://github.com/apache/kyuubi/pull/6611
# :mag: Description
## Issue References ๐
<!-- Append the issue number after #. If there is no issue for you to link create one or -->
<!-- If there are no issues to link, please provide details here. -->
This pull request fixes #6593
## Describe Your Solution ๐ง
The `kill -9 $PID` command directly forces Kyuubi to be shut down.
## Types of changes :bookmark:
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan ๐งช
#### Behavior With This Pull Request :tada:
```
(base) $ bin/kyuubi kill
Stopping org.apache.kyuubi.server.KyuubiServer forcefully.
__ __ __
/` \/` \ /` \ __
\ \ \/ / __ __ __ __ __ __\ \ \____ /\_\
\ \ , < /` \/` \/` \/` \/` \/` \\ \ \__` \/` \
\ \ \ \`\\ \ \_\ \\ \_\ \\ \_\ \\ \ \L\ \ \ \
\ \_\ \_ \/`____ \ \____/ \ \____`\ \_,__/ \ \_\
\/_/\/_/ `/___/> \/___/ \/___/ \/___/ \/_/
/\___/
\/__\/
Bye!
```
---
# Checklist ๐
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
**Be nice. Be informative.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6593] `bin/kyuubi` supports `kill` command [kyuubi]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #6611:
URL: https://github.com/apache/kyuubi/pull/6611#discussion_r1714814023
##########
bin/kyuubi:
##########
@@ -215,6 +216,18 @@ function stop_kyuubi() {
fi
}
+function kill_kyuubi() {
+ if [ -f ${pid} ]; then
+ TARGET_ID="$(cat "$pid")"
+ echo "Stopping $CLASS forcefully."
+ kill -9 $TARGET_ID
+ kyuubi_logo
+ echo "Bye!"
+ else
+ echo "no $CLASS to stop"
Review Comment:
```suggestion
else
echo "no $CLASS to stop"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6593] `bin/kyuubi` supports `kill` command [kyuubi]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #6611:
URL: https://github.com/apache/kyuubi/pull/6611#issuecomment-2286081130
Merged to master, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6593] `bin/kyuubi` supports `kill` command [kyuubi]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #6611: [KYUUBI #6593] `bin/kyuubi` supports `kill` command
URL: https://github.com/apache/kyuubi/pull/6611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6593] `bin/kyuubi` supports `kill` command [kyuubi]
Posted by "BruceWong96 (via GitHub)" <gi...@apache.org>.
BruceWong96 commented on code in PR #6611:
URL: https://github.com/apache/kyuubi/pull/6611#discussion_r1714812688
##########
bin/kyuubi:
##########
@@ -215,6 +216,18 @@ function stop_kyuubi() {
fi
}
+function kill_kyuubi() {
+ if [ -f ${pid} ]; then
Review Comment:
OK, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6593] `bin/kyuubi` supports `kill` command [kyuubi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6611:
URL: https://github.com/apache/kyuubi/pull/6611#issuecomment-2285687688
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/6611?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 0.00%. Comparing base [(`d3e1768`)](https://app.codecov.io/gh/apache/kyuubi/commit/d3e17680f58601bf526929f82fd6f732f4d1644e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`00f8c4c`)](https://app.codecov.io/gh/apache/kyuubi/commit/00f8c4c590fd075843f20498f0ad21ef6719e896?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #6611 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 677 677
Lines 41907 41907
Branches 5721 5721
======================================
Misses 41907 41907
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kyuubi/pull/6611?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #6593][Improvement] Support bin/kyuubi kill command [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #6611:
URL: https://github.com/apache/kyuubi/pull/6611#discussion_r1714805788
##########
bin/kyuubi:
##########
@@ -215,6 +216,18 @@ function stop_kyuubi() {
fi
}
+function kill_kyuubi() {
+ if [ -f ${pid} ]; then
Review Comment:
indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org