You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/01 20:20:39 UTC

[GitHub] [incubator-pinot] yupeng9 commented on pull request #5631: Add the message constraint on all instances in Helix

yupeng9 commented on pull request #5631:
URL: https://github.com/apache/incubator-pinot/pull/5631#issuecomment-652626786


   > Great work digging this out from the Helix code (I'm not able to find this from Helix documentation).
   > 
   > LGTM in general. I suggest renaming all `maxMessages` to `maxStateTransitions` because we are not actually limiting the messages.
   
   Thanks for the code review. Addressed some of the comments


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org