You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by vinodkc <gi...@git.apache.org> on 2017/07/03 13:23:39 UTC

[GitHub] storm pull request #2185: [STORM-2613] Tuples that aren't sampled shouldn't ...

GitHub user vinodkc opened a pull request:

    https://github.com/apache/storm/pull/2185

    [STORM-2613] Tuples that aren't sampled shouldn't be considered for latency calcul…

    
    Set delta to -1 , so that time delay for tuples that aren't sampled will not be added in BoltExecutorStats


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vinodkc/storm-1 br_fix_stat_issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2185
    
----
commit 73c59dcd1a4668c1f1e1fd317cc8f8eb3fe4523e
Author: vinodkc <vi...@gmail.com>
Date:   2017-07-03T12:13:03Z

    Tuples that aren't sampled shouldn't be considered for latency calculation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2185: [STORM-2613] Tuples that aren't sampled shouldn't ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2185


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2185: [STORM-2613] Tuples that aren't sampled shouldn't be cons...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2185
  
    +1 nice finding.
    
    @vinodkc Did you find this spot from 1.x version line? If then could you craft pull request against 1.x-version too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2185: [STORM-2613] Tuples that aren't sampled shouldn't be cons...

Posted by vinodkc <gi...@git.apache.org>.
Github user vinodkc commented on the issue:

    https://github.com/apache/storm/pull/2185
  
    Sure, I'll make a PR against 1.x vesrion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---