You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ManoharVanam <gi...@git.apache.org> on 2017/11/24 07:31:35 UTC
[GitHub] carbondata pull request #1560: [CARBONDATA-1804] Support Plug-gable File Ope...
GitHub user ManoharVanam opened a pull request:
https://github.com/apache/carbondata/pull/1560
[CARBONDATA-1804] Support Plug-gable File Operations based on File types
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [x ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [x ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
Not, Old test cases will take care
- How it is tested? Please attach test report.
Verified in cluster
- Is it a performance related change? Please attach the performance test report.
NO
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ManoharVanam/incubator-carbondata FileFactory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1560.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1560
----
commit 5ea38446f3726aae84a96fa39a203a364e74e5a1
Author: Manohar <ma...@gmail.com>
Date: 2017-11-24T07:10:36Z
[CARBONDATA-1804] Support Plug-gable File Operations based on File types
----
---
[GitHub] carbondata pull request #1560: [CARBONDATA-1804] Support Plug-gable File Ope...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1560#discussion_r153040216
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/DFSFileHolderImpl.java ---
@@ -35,7 +35,7 @@
/**
* cache to hold filename and its stream
*/
- private Map<String, FSDataInputStream> fileNameAndStreamCache;
+ public Map<String, FSDataInputStream> fileNameAndStreamCache;
--- End diff --
member variable should not be public
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1560
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1456/
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1560
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1874/
---
[GitHub] carbondata pull request #1560: [CARBONDATA-1804] Support Plug-gable File Ope...
Posted by ManoharVanam <gi...@git.apache.org>.
Github user ManoharVanam commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1560#discussion_r153059129
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala ---
@@ -353,14 +355,14 @@ class CarbonFileMetastore extends CarbonMetaStore {
val schemaFilePath = carbonTablePath.getSchemaFilePath
val schemaMetadataPath = CarbonTablePath.getFolderContainingFile(schemaFilePath)
tableInfo.setMetaDataFilepath(schemaMetadataPath)
- val fileType = FileFactory.getFileType(schemaMetadataPath)
- if (!FileFactory.isFileExist(schemaMetadataPath, fileType)) {
- FileFactory.mkdirs(schemaMetadataPath, fileType)
- }
- val thriftWriter = new ThriftWriter(schemaFilePath, false)
- thriftWriter.open(FileWriteOperation.OVERWRITE)
- thriftWriter.write(thriftTableInfo)
- thriftWriter.close()
+ val fileType = FileFactory.getFileType(schemaMetadataPath)
--- End diff --
ok
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1560
LGMT
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by ManoharVanam <gi...@git.apache.org>.
Github user ManoharVanam commented on the issue:
https://github.com/apache/carbondata/pull/1560
retest this please
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1560
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1876/
---
[GitHub] carbondata pull request #1560: [CARBONDATA-1804] Support Plug-gable File Ope...
Posted by ManoharVanam <gi...@git.apache.org>.
Github user ManoharVanam commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1560#discussion_r153059130
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/DFSFileHolderImpl.java ---
@@ -35,7 +35,7 @@
/**
* cache to hold filename and its stream
*/
- private Map<String, FSDataInputStream> fileNameAndStreamCache;
+ public Map<String, FSDataInputStream> fileNameAndStreamCache;
--- End diff --
ok
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1560
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1431/
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1560
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1459/
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by ManoharVanam <gi...@git.apache.org>.
Github user ManoharVanam commented on the issue:
https://github.com/apache/carbondata/pull/1560
retest this please
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1560
LGTM
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1560
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1500/
---
[GitHub] carbondata pull request #1560: [CARBONDATA-1804] Support Plug-gable File Ope...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1560#discussion_r153040228
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala ---
@@ -353,14 +355,14 @@ class CarbonFileMetastore extends CarbonMetaStore {
val schemaFilePath = carbonTablePath.getSchemaFilePath
val schemaMetadataPath = CarbonTablePath.getFolderContainingFile(schemaFilePath)
tableInfo.setMetaDataFilepath(schemaMetadataPath)
- val fileType = FileFactory.getFileType(schemaMetadataPath)
- if (!FileFactory.isFileExist(schemaMetadataPath, fileType)) {
- FileFactory.mkdirs(schemaMetadataPath, fileType)
- }
- val thriftWriter = new ThriftWriter(schemaFilePath, false)
- thriftWriter.open(FileWriteOperation.OVERWRITE)
- thriftWriter.write(thriftTableInfo)
- thriftWriter.close()
+ val fileType = FileFactory.getFileType(schemaMetadataPath)
--- End diff --
It seems indentation not correct
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1560
retest this please
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1560
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1542/
---
[GitHub] carbondata pull request #1560: [CARBONDATA-1804] Support Plug-gable File Ope...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1560
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1560
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1858/
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1560
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1943/
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1560
retest sdv please
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1560
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1553/
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1560
Please provide description of this PR @ManoharVanam
---
[GitHub] carbondata issue #1560: [CARBONDATA-1804] Support Plug-gable File Operations...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1560
retest this please
---