You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/15 07:47:33 UTC

[GitHub] [ignite] nizhikov commented on pull request #9001: IGNITE-14516 Always log to not archived segment

nizhikov commented on pull request #9001:
URL: https://github.com/apache/ignite/pull/9001#issuecomment-820201450


   @sergey-chugunov-1985 
   @tkalkirill 
   @Mmuzaf 
   @ivandasch 
   
   I reworked the PR based on your comments and proposals.
   I think we should do the following:
   
   1. Switch to the next segment in `FileWriteAheadLogManager#restoreWriteHandle` if failover iteration stops on `SWITCH_SEGMENT_RECORD`.
   2. Create a flag `WalIterator#switchSegmentRecordReached` to implement 1.
   
   Looks like we have 2 cases when we stop iteration, not on `SWITCH_SEGMENT_RECORD`:
   
   1. Segment is full and `SWITCH_SEGMENT_RECORD` doesn't fill in it - then it doesn't matter when archivation happens, we will have a consistent segment in the archive.
   2. Node fails with the unfilled segment - it's OK to continue to log into it.
   
   Please, take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org