You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Ishaan29 (via GitHub)" <gi...@apache.org> on 2023/05/20 19:39:11 UTC
[GitHub] [eventmesh] Ishaan29 opened a new pull request, #3987: Issue #3827 Changed Access Modifiers for MessageQueue items
Ishaan29 opened a new pull request, #3987:
URL: https://github.com/apache/eventmesh/pull/3987
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3827 .
### Motivation
the issue explains
a. Public class variable fields do not respect the encapsulation principle and has three main disadvantages:
Additional behavior such as validation cannot be added.
The internal representation is exposed, and cannot be changed afterwards.
Member values are subject to change from anywhere in the code and may not meet the programmer’s assumptions.
By using private attributes and accessor methods (set and get), unauthorized modifications are prevented.
b. Overriding or shadowing a variable declared in an outer scope can strongly impact the readability, and therefore the maintainability, of a piece of code. Further, it could lead maintainers to introduce bugs because they think they’re using one variable but are really using another.
### Modifications
- Changed Access modifier of `items[]`
- Added getters for the same
- Changed Breaking tests
- Renamed Method scoped to `reentrantLock`
### Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why? Refactoring and Optimization
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3987: [ISSUE #3827] Changed Access Modifiers for MessageQueue items
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3987:
URL: https://github.com/apache/eventmesh/pull/3987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Ishaan29 commented on pull request #3987: Issue #3827 Changed Access Modifiers for MessageQueue items
Posted by "Ishaan29 (via GitHub)" <gi...@apache.org>.
Ishaan29 commented on PR #3987:
URL: https://github.com/apache/eventmesh/pull/3987#issuecomment-1555979717
hey @mxsm @Alonexc
could you please review this ?
thanks in advance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 commented on pull request #3987: [ISSUE #3827] Changed Access Modifiers for MessageQueue items
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on PR #3987:
URL: https://github.com/apache/eventmesh/pull/3987#issuecomment-1562173761
@Ishaan29 please merge the latest master branch code to your pr, to fix the ci check error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3987: Issue #3827 Changed Access Modifiers for MessageQueue items
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3987:
URL: https://github.com/apache/eventmesh/pull/3987#issuecomment-1558634226
These errors don't appear to be related to your pr submission, but they have been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3987: [ISSUE #3827] Changed Access Modifiers for MessageQueue items
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3987:
URL: https://github.com/apache/eventmesh/pull/3987#issuecomment-1566377517
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3987?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#3987](https://app.codecov.io/gh/apache/eventmesh/pull/3987?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e22cafe) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/782a1275c8f34ebaa0d6423a9c601b0e78c9f7cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (782a127) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head e22cafe differs from pull request most recent head f818de0. Consider uploading reports for the commit f818de0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3987 +/- ##
============================================
- Coverage 14.24% 14.23% -0.01%
- Complexity 1320 1322 +2
============================================
Files 579 579
Lines 28967 28964 -3
Branches 2802 2800 -2
============================================
- Hits 4125 4122 -3
+ Misses 24450 24449 -1
- Partials 392 393 +1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3987?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ntmesh/storage/standalone/broker/MessageQueue.java](https://app.codecov.io/gh/apache/eventmesh/pull/3987?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXN0YW5kYWxvbmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3N0YW5kYWxvbmUvYnJva2VyL01lc3NhZ2VRdWV1ZS5qYXZh) | `68.75% <100.00%> (+0.39%)` | :arrow_up: |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3987/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org