[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #375: Fixed issues with resetting variables

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #375:
URL: https://github.com/apache/incubator-daffodil/pull/375#discussion_r419378478



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/RuntimeData.scala
##########
@@ -994,6 +994,6 @@ final class VariableRuntimeData(
       }
     }
 
-  def newVariableInstance: VariableInstance = VariableInstance(state, value, this, maybeDefaultValueExpr)
+  def newVariableInstance: VariableInstance = VariableInstance(state, value, this, maybeDefaultValueExpr, state, value)

Review comment:
       This isn't clear to me. Why is state and value passed in as both the current state/value and the prior state/value? Seems to me when we create a new variable instance we want the prior state/value to be undefined/no value.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org