You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/19 12:52:37 UTC
[GitHub] flink pull request #4367: [FLINK-4499] Add spotbugs plugin
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4367
[FLINK-4499] Add spotbugs plugin
This PR introduces the spotbugs maven plugin, which is the successor to findbugs.
This PR is partially based on #2422.
The spotbugs checks can be run with maven by specifying "-Dspotbugs" on the command-line. For travis, this is done on the "misc" test group; the only profile that actually builds all modules.
As for the rules, i deactivated all that currently caused failures. I will create follow-up JIRAs to activate rules one-by-one; this should give result in several PRs that are easy and quick to review, and lessens the chance of some draconian rule from slipping through.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 4499
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4367.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4367
----
commit b5abfed7ac6b5e9d21bfe90b8a067ddc56668cbb
Author: zentol <ch...@apache.org>
Date: 2017-07-17T14:59:22Z
[FLINK-4499] Add spotbugs plugin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4367: [FLINK-4499] [build] Add spotbugs plugin
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4367
License isn't an issue since it's only used during the build:
CAN APACHE PROJECTS DISTRIBUTE COMPONENTS UNDER PROHIBITED LICENSES? https://www.apache.org/legal/resolved.html#prohibited
Apache projects cannot distribute any such components. This means that no source code can be from Category X and that any convenience binaries produced may not include such contents. As with the previous question on platforms, the component can be relied on if the component's license terms do not affect the Apache product's licensing. For example, using a GPL'ed tool during the build is OK, however including GPL'ed source code is not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4367: [FLINK-4499] [build] Add spotbugs plugin
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4367
looks like the build times increase by 5-10 minutes but I'd say this is worth it
+1 from my side
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4367: [FLINK-4499] [build] Add spotbugs plugin
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4367
The "spiritual successor". Can we actually use this? I'm asking because it's LGPL. It's probably ok because it's only a build plugin, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4367: [FLINK-4499] [build] Add spotbugs plugin
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4367
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4367: [FLINK-4499] [build] Add spotbugs plugin
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4367
I was wondering the same, but figured that it's okay since it is neither required to build/run Flink nor included in the binary release and optional to boot. FYI, the checkstyle plugin is also released under LGPL (not the maven plugin, but the underlying checkstyle engine).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4367: [FLINK-4499] [build] Add spotbugs plugin
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4367
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---