[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10399: feat: refresh control panel select forms to look more like SIP-34

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #10399:
URL: https://github.com/apache/incubator-superset/pull/10399#discussion_r460641631



##########
File path: superset-frontend/src/explore/main.less
##########
@@ -61,6 +61,11 @@
   background-color: transparent !important;
 }
 
+.fa-caret-up,
+.fa-caret-down {
+  color: #666666;

Review comment:
       can you find this color in the variables less file and use the variable here?

##########
File path: superset-frontend/src/components/Select/styles.tsx
##########
@@ -142,6 +142,8 @@ export const DEFAULT_STYLES: PartialStylesConfig = {
     return [
       provider,
       css`
+        border-width: ${isMulti ? '1px' : '0px'};
+        background-color: ${isMulti ? 'white' : '#F0F0F0'};

Review comment:
       these colors should probably be found within `supersetColors`, otherwise they should be added there

##########
File path: superset-frontend/src/explore/main.less
##########
@@ -80,9 +85,14 @@
     margin-left: 15px;
     padding-bottom: 0px;
   }
-
+  .panel-title {
+    color: #b2b2b2;
+  }
   .control-label {
     margin-bottom: 0px;
+    font-size: 14px;
+    font-weight: 500;
+    color: #b2b2b2;

Review comment:
       can you find this color in the variables less file and use the variable here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org