[GitHub] villebro opened a new pull request #5686: [bugfix] Improve column name case alignment logic

[GitBox <gi...@apache.org>]

villebro opened a new pull request #5686: [bugfix] Improve column name case alignment logic
URL: https://github.com/apache/incubator-superset/pull/5686
 
 
   The original implementation of renaming dataframe column names to correspond to columns in form data was missing key metrics, grouping and spatial columns. To avoid having the same logic defined in several places, new constants `GROUPING_KEYS` and `SPATIAL_KEYS` were added to `viz.py`, and `get_spatial_columns()` function was moved to `utils`. The redundant `BaseViz.get_metric_label()` method was also removed and references pointed to `utils.get_metric_names()` which contained the same logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org