[GitHub] [maven-resolver] michael-o commented on a change in pull request #122: Document all named locks and name mappers

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #122:
URL: https://github.com/apache/maven-resolver/pull/122#discussion_r703332941



##########
File path: maven-resolver-named-locks-redisson/src/site/markdown/index.md.vm
##########
@@ -60,6 +60,6 @@ ${esc.hash}${esc.hash} Installation/Testing
   ├── <a href="https://repo1.maven.org/maven2/io/netty/netty-resolver-dns/4.1.65.Final/netty-resolver-dns-4.1.65.Final.jar">netty-resolver-dns-4.1.65.Final.jar</a>
   ├── <a href="https://repo1.maven.org/maven2/io/netty/netty-transport/4.1.65.Final/netty-transport-4.1.65.Final.jar">netty-transport-4.1.65.Final.jar</a>
   ├── <a href="https://repo1.maven.org/maven2/org/redisson/redisson/3.15.6/redisson-3.15.6.jar">redisson-3.15.6.jar</a>
-  ├── <a href="https://repo1.maven.org/maven2/org/yaml/snakeyaml/1.27/snakeyaml-1.27.jar">snakeyaml-1.27.jar</a></pre>
+  └── <a href="https://repo1.maven.org/maven2/org/yaml/snakeyaml/1.27/snakeyaml-1.27.jar">snakeyaml-1.27.jar</a></pre>

Review comment:
       One of the problems is that we cannot deliver it with Maven because it is try immediate to connect to Redis, not to mention the dependency overhead.
   What we could do:
   1. Already add the config line in `m2.conf` by default
   2. Provide an additional binary distro based on a profile. Though, I don't know yet how to do best. I would appreciate if someone from the community can create a proposal and a subsequent PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org