You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2019/03/29 04:49:09 UTC

[incubator-skywalking] branch zipkin-trace updated: Fix wrong latency.

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch zipkin-trace
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git


The following commit(s) were added to refs/heads/zipkin-trace by this push:
     new 331a750  Fix wrong latency.
331a750 is described below

commit 331a7502e1c21aba676f63ead45b7aefff5be244
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Thu Mar 28 21:48:59 2019 -0700

    Fix wrong latency.
---
 .../skywalking/oap/server/receiver/zipkin/trace/SpanForward.java    | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/oap-server/server-receiver-plugin/zipkin-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zipkin/trace/SpanForward.java b/oap-server/server-receiver-plugin/zipkin-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zipkin/trace/SpanForward.java
index 8cf3ed0..3d38868 100644
--- a/oap-server/server-receiver-plugin/zipkin-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zipkin/trace/SpanForward.java
+++ b/oap-server/server-receiver-plugin/zipkin-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zipkin/trace/SpanForward.java
@@ -95,10 +95,12 @@ public class SpanForward {
                 zipkinSpan.setTimeBucket(timeBucket);
             }
 
-            zipkinSpan.setEndTime(startTime + span.durationAsLong() / 1000);
+            long latency = span.durationAsLong() / 1000;
+
+            zipkinSpan.setEndTime(startTime + latency);
             zipkinSpan.setIsError(BooleanUtils.booleanToValue(false));
             zipkinSpan.setEncode(SpanEncode.PROTO3);
-            zipkinSpan.setLatency((int)span.durationAsLong());
+            zipkinSpan.setLatency((int)latency);
             zipkinSpan.setDataBinary(SpanBytesEncoder.PROTO3.encode(span));
 
             receiver.receive(zipkinSpan);