You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2015/11/18 07:58:51 UTC
Re: Review Request 40375: [WIP] Support distinguishing revocable
resources in the Resource protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated Nov. 18, 2015, 2:58 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Working on resources.cpp & UT
Summary (updated)
-----------------
[WIP] Support distinguishing revocable resources in the Resource protobuf.
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs
-----
include/mesos/mesos.proto 5ad48bd
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: [WIP] Support distinguishing revocable
resources in the Resource protobuf.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review106999
-----------------------------------------------------------
Do we also need to add this support in v1/mesos.proto?
- Qian Zhang
On Nov. 18, 2015, 2:58 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 2:58 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5ad48bd
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: [WIP] Support distinguishing revocable
resources in the Resource protobuf.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107493
-----------------------------------------------------------
include/mesos/mesos.proto (line 643)
<https://reviews.apache.org/r/40375/#comment166725>
s/oversubscription/oversubscription for allocations
include/mesos/mesos.proto (line 647)
<https://reviews.apache.org/r/40375/#comment166609>
The project name may need update to ""oversubscription for reservations"
src/tests/resources_tests.cpp (line 802)
<https://reviews.apache.org/r/40375/#comment166621>
s/Standard/USAGE_SLACK
src/tests/resources_tests.cpp (lines 804 - 805)
<https://reviews.apache.org/r/40375/#comment166732>
one line
src/tests/resources_tests.cpp (lines 812 - 813)
<https://reviews.apache.org/r/40375/#comment166733>
one line
src/tests/resources_tests.cpp (line 1899)
<https://reviews.apache.org/r/40375/#comment166728>
new line
src/tests/resources_tests.cpp (line 1929)
<https://reviews.apache.org/r/40375/#comment166729>
new line
src/tests/resources_tests.cpp (line 1931)
<https://reviews.apache.org/r/40375/#comment166730>
new line
src/tests/resources_tests.cpp (line 1933)
<https://reviews.apache.org/r/40375/#comment166731>
new line
src/tests/resources_tests.cpp (line 1937)
<https://reviews.apache.org/r/40375/#comment166727>
I think we can still use "sum" here
src/tests/resources_tests.cpp (line 1961)
<https://reviews.apache.org/r/40375/#comment166726>
s/revocable/USAGE_SLACK revocable
- Guangya Liu
On 十一月 21, 2015, 3:47 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated 十一月 21, 2015, 3:47 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5ad48bd
> include/mesos/v1/mesos.proto e71ddda
> src/common/resources.cpp f1da323
> src/tests/resources_tests.cpp 0d084fd
> src/v1/resources.cpp 6f50101
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: [WIP] Support distinguishing revocable
resources in the Resource protobuf.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107529
-----------------------------------------------------------
src/common/resources.cpp (lines 94 - 106)
<https://reviews.apache.org/r/40375/#comment166742>
For compatibility issue, shall we take no_type same as USAGE_SLACK?
- Guangya Liu
On 十一月 21, 2015, 3:47 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated 十一月 21, 2015, 3:47 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5ad48bd
> include/mesos/v1/mesos.proto e71ddda
> src/common/resources.cpp f1da323
> src/tests/resources_tests.cpp 0d084fd
> src/v1/resources.cpp 6f50101
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: [WIP] Support distinguishing revocable
resources in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, line 1982
> > <https://reviews.apache.org/r/40375/diff/3/?file=1138257#file1138257line1982>
> >
> > EXPECT_TRUE((r3 - r3).empty());
This is added the previous code, so i'd like to drop this issue.
> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, line 1986
> > <https://reviews.apache.org/r/40375/diff/3/?file=1138257#file1138257line1986>
> >
> > Add EXPECT_TRUE((r5 - r5).empty());
ditto
> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, lines 1941-1948
> > <https://reviews.apache.org/r/40375/diff/3/?file=1138257#file1138257line1941>
> >
> > new line to split.
> >
> > It is suggested to add new line if one sentense is split to two lines.
I keep the same style with other code in `resources_test.cpp`, so i'd like to keep it as is.
> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 649
> > <https://reviews.apache.org/r/40375/diff/3/?file=1138254#file1138254line649>
> >
> > Did you get out how to leverage this default value in the code? ;-)
Did not try it, but I think calling `mutable_type()` (or similar) will set the type. `mutable_revocable()` will only create revocable object instead of RevocableInfo::type.
> On Nov. 24, 2015, 4:26 p.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, line 800
> > <https://reviews.apache.org/r/40375/diff/3/?file=1138257#file1138257line800>
> >
> > Do we need to update this? The standard revocable resource should be usage slack
I mean unset RevocableInfo::type; maybe `Unset RevocableInfo::type revocable resource` is better.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107732
-----------------------------------------------------------
On Nov. 24, 2015, 3:24 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 3:24 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0b8289f
> include/mesos/v1/mesos.proto c98f2a4
> src/common/resources.cpp b4abf54
> src/tests/resources_tests.cpp dbd39cd
> src/v1/resources.cpp 8488c31
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: [WIP] Support distinguishing revocable
resources in the Resource protobuf.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107732
-----------------------------------------------------------
include/mesos/mesos.proto (line 649)
<https://reviews.apache.org/r/40375/#comment167021>
Did you get out how to leverage this default value in the code? ;-)
src/common/resources.cpp (lines 92 - 93)
<https://reviews.apache.org/r/40375/#comment167020>
// To keep backward compatibility, resources without revocable type are considered same as resources with USAGE_SLACK type.
src/common/resources.cpp (lines 94 - 95)
<https://reviews.apache.org/r/40375/#comment167006>
bool operator==(
const Resource::RevocableInfo& left,
const Resource::RevocableInfo& right)
src/common/resources.cpp (lines 115 - 116)
<https://reviews.apache.org/r/40375/#comment167007>
bool operator!=(
const Resource::RevocableInfo& left,
const Resource::RevocableInfo& right)
src/tests/resources_tests.cpp (line 800)
<https://reviews.apache.org/r/40375/#comment167009>
Do we need to update this? The standard revocable resource should be usage slack
src/tests/resources_tests.cpp (lines 1908 - 1909)
<https://reviews.apache.org/r/40375/#comment167013>
new line
src/tests/resources_tests.cpp (lines 1912 - 1913)
<https://reviews.apache.org/r/40375/#comment167014>
new line
src/tests/resources_tests.cpp (lines 1941 - 1948)
<https://reviews.apache.org/r/40375/#comment167015>
new line to split.
It is suggested to add new line if one sentense is split to two lines.
src/tests/resources_tests.cpp (line 1982)
<https://reviews.apache.org/r/40375/#comment167016>
EXPECT_TRUE((r3 - r3).empty());
src/tests/resources_tests.cpp (line 1986)
<https://reviews.apache.org/r/40375/#comment167017>
Add EXPECT_TRUE((r5 - r5).empty());
src/v1/resources.cpp (lines 93 - 105)
<https://reviews.apache.org/r/40375/#comment167019>
update this to handle backward compatibility issue
src/v1/resources.cpp (lines 1365 - 1368)
<https://reviews.apache.org/r/40375/#comment167018>
Losing no type case
- Guangya Liu
On 十一月 24, 2015, 7:24 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated 十一月 24, 2015, 7:24 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0b8289f
> include/mesos/v1/mesos.proto c98f2a4
> src/common/resources.cpp b4abf54
> src/tests/resources_tests.cpp dbd39cd
> src/v1/resources.cpp 8488c31
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107923
-----------------------------------------------------------
src/tests/resources_tests.cpp (line 1982)
<https://reviews.apache.org/r/40375/#comment167259>
move this to 1987 as we discussed
- Guangya Liu
On 十一月 24, 2015, 2:48 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated 十一月 24, 2015, 2:48 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0b8289f
> include/mesos/v1/mesos.proto c98f2a4
> src/common/resources.cpp b4abf54
> src/tests/resources_tests.cpp dbd39cd
> src/v1/resources.cpp 8488c31
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review107919
-----------------------------------------------------------
src/v1/resources.cpp (line 95)
<https://reviews.apache.org/r/40375/#comment167252>
bool operator==(
const Resource::RevocableInfo& left,
const Resource::RevocableInfo& right)
src/v1/resources.cpp (lines 116 - 117)
<https://reviews.apache.org/r/40375/#comment167253>
bool operator!=(
const Resource::RevocableInfo& left,
const Resource::RevocableInfo& right)
- Guangya Liu
On 十一月 24, 2015, 2:48 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated 十一月 24, 2015, 2:48 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0b8289f
> include/mesos/v1/mesos.proto c98f2a4
> src/common/resources.cpp b4abf54
> src/tests/resources_tests.cpp dbd39cd
> src/v1/resources.cpp 8488c31
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
> On Dec. 1, 2015, 9:57 a.m., Joseph Wu wrote:
> > include/mesos/mesos.proto, line 653
> > <https://reviews.apache.org/r/40375/diff/5/?file=1146482#file1146482line653>
> >
> > Can you note that this is effectively required?
> >
> > i.e. Internally, we will ensure a `type` exists in all valid resources. (This may simplify some other code.)
Yes; to keep the compatibility when serializing, I changed it to `optional`.
> On Dec. 1, 2015, 9:57 a.m., Joseph Wu wrote:
> > src/common/resources.cpp, lines 1402-1405
> > <https://reviews.apache.org/r/40375/diff/5/?file=1146484#file1146484line1402>
> >
> > What are the backwards compatibility requirements for this?
I update the `operator<<` to return `{REV}` when `has_type()` return false.
> On Dec. 1, 2015, 9:57 a.m., Joseph Wu wrote:
> > src/common/resources.cpp, lines 98-110
> > <https://reviews.apache.org/r/40375/diff/5/?file=1146484#file1146484line98>
> >
> > Note: When you specify a default, it is safe to call `protobuf.type()` without checking if it exists first.
> >
> > See: https://developers.google.com/protocol-buffers/docs/proto#optional
> >
> > So minimally, you could just `return left.type() == right.type();`. (But if you do this, you need to comment about the default.)
Agree, use `return left.type() == right.type()` for `operator==`.
> On Dec. 1, 2015, 9:57 a.m., Joseph Wu wrote:
> > include/mesos/mesos.proto, lines 644-650
> > <https://reviews.apache.org/r/40375/diff/5/?file=1146482#file1146482line644>
> >
> > Can you expand a little on these enum descriptions?
> >
> > Ideally, these should include:
> > * A brief definition of each resource type.
> > * Which components control the resource and briefly how they exert control.
Sure, I'll update comments accordingly.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review108438
-----------------------------------------------------------
On Nov. 25, 2015, 2:16 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 2:16 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 27971fe
> include/mesos/v1/mesos.proto 9acefd5
> src/common/resources.cpp b4abf54
> src/tests/resources_tests.cpp dbd39cd
> src/v1/resources.cpp 8488c31
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review108438
-----------------------------------------------------------
include/mesos/mesos.proto (lines 644 - 650)
<https://reviews.apache.org/r/40375/#comment167897>
Can you expand a little on these enum descriptions?
Ideally, these should include:
* A brief definition of each resource type.
* Which components control the resource and briefly how they exert control.
include/mesos/mesos.proto (line 653)
<https://reviews.apache.org/r/40375/#comment167899>
Can you note that this is effectively required?
i.e. Internally, we will ensure a `type` exists in all valid resources. (This may simplify some other code.)
src/common/resources.cpp (lines 98 - 110)
<https://reviews.apache.org/r/40375/#comment167898>
Note: When you specify a default, it is safe to call `protobuf.type()` without checking if it exists first.
See: https://developers.google.com/protocol-buffers/docs/proto#optional
So minimally, you could just `return left.type() == right.type();`. (But if you do this, you need to comment about the default.)
src/common/resources.cpp (lines 1402 - 1405)
<https://reviews.apache.org/r/40375/#comment167901>
What are the backwards compatibility requirements for this?
src/tests/resources_tests.cpp (line 804)
<https://reviews.apache.org/r/40375/#comment167902>
This shouldn't pass after your modifications.
- Joseph Wu
On Nov. 24, 2015, 10:16 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 10:16 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 27971fe
> include/mesos/v1/mesos.proto 9acefd5
> src/common/resources.cpp b4abf54
> src/tests/resources_tests.cpp dbd39cd
> src/v1/resources.cpp 8488c31
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review109902
-----------------------------------------------------------
Can you please rebase this patch? I cannot apply this for test now due to code conflict. Thanks!
- Guangya Liu
On Dec. 1, 2015, 1:15 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 1:15 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 27971fe
> include/mesos/v1/mesos.proto 9acefd5
> src/common/resources.cpp 98804a4
> src/tests/resources_tests.cpp dbd39cd
> src/v1/resources.cpp 8488c31
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
> On Dec. 12, 2015, 3:47 a.m., Joseph Wu wrote:
> > src/common/resources.cpp, lines 1380-1382
> > <https://reviews.apache.org/r/40375/diff/8/?file=1159654#file1159654line1380>
> >
> > I'm not sure if this is necessary.
> >
> > To be as backwards compatible as possible, the `USAGE_SLACK` type would output as `{REV}`. But is there any parsing of stringified `Resources` between the master and agent?
The communitcation between master and agent should be fine, we passed all UT with the patch.
Just not sure whether the 3rd part application will pass endpoint's output. If we updated it, we should drop an email to dev@; any comments?
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review109993
-----------------------------------------------------------
On Dec. 12, 2015, 11:19 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 11:19 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8ca2130
> include/mesos/v1/mesos.proto 8f357b0
> src/common/resources.cpp 5a79817
> src/tests/resources_tests.cpp ce47bac
> src/v1/resources.cpp d300842
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Guangya Liu <gy...@gmail.com>.
> On Dec. 11, 2015, 7:47 p.m., Joseph Wu wrote:
> > src/common/resources.cpp, lines 1380-1382
> > <https://reviews.apache.org/r/40375/diff/8/?file=1159654#file1159654line1380>
> >
> > I'm not sure if this is necessary.
> >
> > To be as backwards compatible as possible, the `USAGE_SLACK` type would output as `{REV}`. But is there any parsing of stringified `Resources` between the master and agent?
>
> Klaus Ma wrote:
> The communitcation between master and agent should be fine, we passed all UT with the patch.
> Just not sure whether the 3rd part application will pass endpoint's output. If we updated it, we should drop an email to dev@; any comments?
The {REV}, {ALLOCATION_SLACK}, {USAGE_SLACK} are only for tracing some logs in master and agent, end user need to use API to set different revocable types. So I think that we can keep this as it is for now. Thanks.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review109993
-----------------------------------------------------------
On Dec. 12, 2015, 3:19 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 3:19 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8ca2130
> include/mesos/v1/mesos.proto 8f357b0
> src/common/resources.cpp 5a79817
> src/tests/resources_tests.cpp ce47bac
> src/v1/resources.cpp d300842
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review109993
-----------------------------------------------------------
src/common/resources.cpp (line 103)
<https://reviews.apache.org/r/40375/#comment169741>
Missing a comment here about optional protobuf fields with defaults.
src/common/resources.cpp (lines 1380 - 1382)
<https://reviews.apache.org/r/40375/#comment169746>
I'm not sure if this is necessary.
To be as backwards compatible as possible, the `USAGE_SLACK` type would output as `{REV}`. But is there any parsing of stringified `Resources` between the master and agent?
src/common/resources.cpp (lines 1404 - 1405)
<https://reviews.apache.org/r/40375/#comment169748>
This comment should be updated.
src/v1/resources.cpp (line 97)
<https://reviews.apache.org/r/40375/#comment169749>
Ditto: comment here.
src/v1/resources.cpp (lines 1364 - 1366)
<https://reviews.apache.org/r/40375/#comment169750>
Ditto: not necessary, perhaps.
src/v1/resources.cpp (lines 1388 - 1389)
<https://reviews.apache.org/r/40375/#comment169751>
Ditto: Update comment.
- Joseph Wu
On Dec. 10, 2015, 5:21 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 5:21 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8ca2130
> include/mesos/v1/mesos.proto 8f357b0
> src/common/resources.cpp 5a79817
> src/tests/resources_tests.cpp ce47bac
> src/v1/resources.cpp d300842
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review113094
-----------------------------------------------------------
Ship it!
A few comment suggestions, but otherwise LGTM.
include/mesos/mesos.proto (line 661)
<https://reviews.apache.org/r/40375/#comment173600>
s/that controlled/controlled/
include/mesos/mesos.proto (lines 661 - 662)
<https://reviews.apache.org/r/40375/#comment173601>
s/by oversubscription for allocations (QoSController & ResourceEstimator)/by the `QoSController` and `ResourceEstimator`/
s/`ResourceEstimator`/The `ResourceEstimator`/
include/mesos/mesos.proto (line 663)
<https://reviews.apache.org/r/40375/#comment173602>
s/marks allocated by not used resources/marks resources that are allocated but not utilized/
include/mesos/mesos.proto (line 667)
<https://reviews.apache.org/r/40375/#comment173603>
s/that controlled/controlled/
include/mesos/mesos.proto (lines 667 - 668)
<https://reviews.apache.org/r/40375/#comment173604>
s/by oversubscription for reservations (Allocator)/by the allocator, when oversubscription for reservations is enabled/
include/mesos/mesos.proto (lines 668 - 669)
<https://reviews.apache.org/r/40375/#comment173605>
s/reserved by not allocated resources/resources that are reserved but not allocated/
- Joseph Wu
On Dec. 12, 2015, 7:19 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 7:19 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8ca2130
> include/mesos/v1/mesos.proto 8f357b0
> src/common/resources.cpp 5a79817
> src/tests/resources_tests.cpp ce47bac
> src/v1/resources.cpp d300842
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review123538
-----------------------------------------------------------
src/common/resources.cpp (line 187)
<https://reviews.apache.org/r/40375/#comment185785>
update to throttle_info
src/common/resources.cpp (lines 1551 - 1553)
<https://reviews.apache.org/r/40375/#comment185784>
update to throttle_info
- Guangya Liu
On 三月 14, 2016, 7:12 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated 三月 14, 2016, 7:12 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a
> include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144
> src/common/resources.cpp 1f23dc83f7330c305a836d698f114b7eaf3d7ba1
> src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
> src/v1/resources.cpp c6f125ec317e2da537a6456f5cff2da0a48701d8
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated March 16, 2016, 10:12 a.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Update descriptions.
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description (updated)
-------
MESOS-3888: Distinguish revocable resource to throttleable and non-throttleable.
Diffs
-----
include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b
include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b
src/common/resources.cpp 1f23dc83f7330c305a836d698f114b7eaf3d7ba1
src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
src/v1/resources.cpp c6f125ec317e2da537a6456f5cff2da0a48701d8
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated March 15, 2016, 6:02 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Updated test/helper for new protobuf.
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b
include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b
src/common/resources.cpp 1f23dc83f7330c305a836d698f114b7eaf3d7ba1
src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
src/v1/resources.cpp c6f125ec317e2da537a6456f5cff2da0a48701d8
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated March 14, 2016, 3:12 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Add ThrottleInfo to un-block next patches; will remove RevocableInfo.Type in next patches.
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a
include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144
src/common/resources.cpp 1f23dc83f7330c305a836d698f114b7eaf3d7ba1
src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c
src/v1/resources.cpp c6f125ec317e2da537a6456f5cff2da0a48701d8
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated March 11, 2016, 11:21 a.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
rebase.
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto 56d456acfd35fa59f394b27d62f62772eec03f6a
include/mesos/v1/mesos.proto 4fba77464bb052d27c424f7721397142850b1144
src/common/resources.cpp cf0707209143084d86aff5e4427846f461479c54
src/tests/resources_tests.cpp 5357275833383bbff055689c8c1d0fa59791f2d0
src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
> On Feb. 4, 2016, 7:43 p.m., Alexander Rukletsov wrote:
> > include/mesos/mesos.proto, lines 643-649
> > <https://reviews.apache.org/r/40375/diff/10/?file=1185761#file1185761line643>
> >
> > This looks like an internal information, the *source* of a revocable resource. While we definitely need this is the allocator, I'm not sure we should expose it in the public protobuf. I think frameworks are more interested in the *quality* of a resource. Can we keep the source private somehow?
Framework need to know revocable type as master did not allow to use both USAGE_SLACK and ALLOCATION_SLACK for one task; it's because the controller (QoSController & evicting modules) is different for now.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review117796
-----------------------------------------------------------
On Jan. 7, 2016, 11:43 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 11:43 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6
> include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
> src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4
> src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review117796
-----------------------------------------------------------
include/mesos/mesos.proto (lines 643 - 649)
<https://reviews.apache.org/r/40375/#comment179057>
This looks like an internal information, the *source* of a revocable resource. While we definitely need this is the allocator, I'm not sure we should expose it in the public protobuf. I think frameworks are more interested in the *quality* of a resource. Can we keep the source private somehow?
- Alexander Rukletsov
On Jan. 7, 2016, 3:43 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2016, 3:43 a.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6
> include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
> src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4
> src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320
> src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 11:43 a.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Address review comments
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6
include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4
src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320
src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated Dec. 12, 2015, 11:19 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Address comments
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto 8ca2130
include/mesos/v1/mesos.proto 8f357b0
src/common/resources.cpp 5a79817
src/tests/resources_tests.cpp ce47bac
src/v1/resources.cpp d300842
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated Dec. 11, 2015, 9:21 a.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
rebase
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto 8ca2130
include/mesos/v1/mesos.proto 8f357b0
src/common/resources.cpp 5a79817
src/tests/resources_tests.cpp ce47bac
src/v1/resources.cpp d300842
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review109325
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十二月 1, 2015, 1:15 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
>
> (Updated 十二月 1, 2015, 1:15 p.m.)
>
>
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3888
> https://issues.apache.org/jira/browse/MESOS-3888
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 27971fe
> include/mesos/v1/mesos.proto 9acefd5
> src/common/resources.cpp 98804a4
> src/tests/resources_tests.cpp dbd39cd
> src/v1/resources.cpp 8488c31
>
> Diff: https://reviews.apache.org/r/40375/diff/
>
>
> Testing
> -------
>
> make && make check
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated Dec. 1, 2015, 9:15 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Add comments for `RevocableInfo::Type`
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto 27971fe
include/mesos/v1/mesos.proto 9acefd5
src/common/resources.cpp 98804a4
src/tests/resources_tests.cpp dbd39cd
src/v1/resources.cpp 8488c31
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated Dec. 1, 2015, 3:31 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Address comments
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto 27971fe
include/mesos/v1/mesos.proto 9acefd5
src/common/resources.cpp 98804a4
src/tests/resources_tests.cpp dbd39cd
src/v1/resources.cpp 8488c31
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 2:16 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Address comments
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto 27971fe
include/mesos/v1/mesos.proto 9acefd5
src/common/resources.cpp b4abf54
src/tests/resources_tests.cpp dbd39cd
src/v1/resources.cpp 8488c31
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: Support distinguishing revocable resources
in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 10:48 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Summary (updated)
-----------------
Support distinguishing revocable resources in the Resource protobuf.
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs
-----
include/mesos/mesos.proto 0b8289f
include/mesos/v1/mesos.proto c98f2a4
src/common/resources.cpp b4abf54
src/tests/resources_tests.cpp dbd39cd
src/v1/resources.cpp 8488c31
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: [WIP] Support distinguishing revocable
resources in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 7:35 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Address comments.
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto 0b8289f
include/mesos/v1/mesos.proto c98f2a4
src/common/resources.cpp b4abf54
src/tests/resources_tests.cpp dbd39cd
src/v1/resources.cpp 8488c31
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: [WIP] Support distinguishing revocable
resources in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 3:24 p.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Keep the compatibility of unset RevocableInfo::type & RevocableInfo::USAGE_SLACK
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto 0b8289f
include/mesos/v1/mesos.proto c98f2a4
src/common/resources.cpp b4abf54
src/tests/resources_tests.cpp dbd39cd
src/v1/resources.cpp 8488c31
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
Re: Review Request 40375: [WIP] Support distinguishing revocable
resources in the Resource protobuf.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/
-----------------------------------------------------------
(Updated Nov. 21, 2015, 11:47 a.m.)
Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van Remoortere.
Changes
-------
Address comments
Bugs: MESOS-3888
https://issues.apache.org/jira/browse/MESOS-3888
Repository: mesos
Description
-------
MESOS-3888: We need to distinguish revocable resource for usage slack and allocation slack.
Diffs (updated)
-----
include/mesos/mesos.proto 5ad48bd
include/mesos/v1/mesos.proto e71ddda
src/common/resources.cpp f1da323
src/tests/resources_tests.cpp 0d084fd
src/v1/resources.cpp 6f50101
Diff: https://reviews.apache.org/r/40375/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma