Re: Review Request 43829: Effective time in Entity updates.

[pavan kumar kolamuri <pa...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43829/#review122283
-----------------------------------------------------------




client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java (line 126)
<https://reviews.apache.org/r/43829/#comment184237>

    Description is not clear. Can you please change it



client/src/main/java/org/apache/falcon/client/FalconClient.java (line 405)
<https://reviews.apache.org/r/43829/#comment184238>

    StringUtilsisBlank here also please



common/src/main/java/org/apache/falcon/entity/ProcessHelper.java (line 99)
<https://reviews.apache.org/r/43829/#comment184469>

    Null check required right ?



common/src/main/java/org/apache/falcon/update/UpdateHelper.java (line 140)
<https://reviews.apache.org/r/43829/#comment184493>

    What exactly key and value contains in checksumfile?



common/src/main/java/org/apache/falcon/update/UpdateHelper.java (line 144)
<https://reviews.apache.org/r/43829/#comment184497>

    If user doesn't specify lib path in process, i think oozie will take lib path from workflowpath/lib. Can you please check once



common/src/main/java/org/apache/falcon/update/UpdateHelper.java (line 188)
<https://reviews.apache.org/r/43829/#comment184478>

    why new configuration ?



common/src/main/java/org/apache/falcon/update/UpdateHelper.java (line 195)
<https://reviews.apache.org/r/43829/#comment184479>

    Can you move getCheckSum to method



common/src/main/java/org/apache/falcon/update/UpdateHelper.java (line 215)
<https://reviews.apache.org/r/43829/#comment184495>

    when dest can be null ? Shouldn't we throw exception at first when destination is null



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 1256)
<https://reviews.apache.org/r/43829/#comment184496>

    Change method name as we are checking both workflow path and lib path.



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 320)
<https://reviews.apache.org/r/43829/#comment184470>

    Why are you setting cluster start time as effective time ?



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 329)
<https://reviews.apache.org/r/43829/#comment184471>

    isBlank



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 344)
<https://reviews.apache.org/r/43829/#comment184473>

    This MyeffectiveTime is not used anywhere



prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 1199)
<https://reviews.apache.org/r/43829/#comment184475>

    Same method available in DateUtil use it.


- pavan kumar kolamuri


On Feb. 23, 2016, 12:43 p.m., sandeep samudrala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43829/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 12:43 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1406
>     https://issues.apache.org/jira/browse/FALCON-1406
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> FALCON-1406. Initial patch for effective time in EntityMutations
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconCLI.java a1f42ce 
>   client/src/main/java/org/apache/falcon/cli/FalconEntityCLI.java 6f9d620 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java 4f86d9b 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 597f608 
>   common/src/main/java/org/apache/falcon/entity/EntityUtil.java 96befa1 
>   common/src/main/java/org/apache/falcon/entity/FileSystemStorage.java ece8b5d 
>   common/src/main/java/org/apache/falcon/entity/ProcessHelper.java bbfca68 
>   common/src/main/java/org/apache/falcon/update/UpdateHelper.java 6603bc6 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionArgs.java 3363e1f 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java 5866369 
>   common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java faea25c 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java b899a58 
>   oozie/src/main/java/org/apache/falcon/oozie/ExportWorkflowBuilder.java a55656c 
>   oozie/src/main/java/org/apache/falcon/oozie/ImportWorkflowBuilder.java cae8497 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieBundleBuilder.java 5f93cc2 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieCoordinatorBuilder.java f555b64 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieEntityBuilder.java a36ee79 
>   oozie/src/main/java/org/apache/falcon/oozie/OozieOrchestrationWorkflowBuilder.java e137e11 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedBundleBuilder.java c758411 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedReplicationWorkflowBuilder.java 5a62130 
>   oozie/src/main/java/org/apache/falcon/oozie/feed/FeedRetentionWorkflowBuilder.java b9e3848 
>   oozie/src/main/java/org/apache/falcon/oozie/process/HiveProcessWorkflowBuilder.java 9f9579c 
>   oozie/src/main/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilder.java f93a599 
>   oozie/src/main/java/org/apache/falcon/oozie/process/PigProcessWorkflowBuilder.java a1a7c12 
>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessBundleBuilder.java 806810e 
>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionCoordinatorBuilder.java f5c9948 
>   oozie/src/main/java/org/apache/falcon/oozie/process/ProcessExecutionWorkflowBuilder.java 7d5b331 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java ebf23da 
>   oozie/src/test/java/org/apache/falcon/oozie/process/OozieProcessWorkflowBuilderTest.java 8d824ba 
>   prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 3ebe612 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java b35ae9a 
>   prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java 2dc727d 
>   rerun/src/main/java/org/apache/falcon/rerun/handler/RetryHandler.java fac32b3 
>   rerun/src/main/java/org/apache/falcon/rerun/queue/ActiveMQueue.java 3168c31 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java 7ce2420 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 37221f3 
>   unit/src/main/java/org/apache/falcon/unit/LocalSchedulableEntityManager.java 7398c8a 
>   unit/src/test/java/org/apache/falcon/unit/TestFalconUnit.java aaf2b37 
>   webapp/src/main/java/org/apache/falcon/resource/ConfigSyncService.java aa15dcc 
>   webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java e97adff 
>   webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java a1668c1 
>   webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f336422 
> 
> Diff: https://reviews.apache.org/r/43829/diff/
> 
> 
> Testing
> -------
> 
> Bit of manual testing done. I will further beautify the code along with few more UTS(which I am fixing currently). Till then consider this for functional review.
> 
> 
> Thanks,
> 
> sandeep samudrala
> 
>