You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2021/10/21 16:38:57 UTC

[kudu-CR] [KUDU-3330] Define operator<< for MonoTime 

Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17961


Change subject: [KUDU-3330] Define operator<< for MonoTime
......................................................................

[KUDU-3330] Define operator<< for MonoTime

This patch implements the operator<< for MonoTime. This is needed for
CHECK_XX and DCHECK_XX on MonoTime.

Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
---
M src/kudu/util/monotime.cc
M src/kudu/util/monotime.h
2 files changed, 20 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/17961/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Oct 2021 20:03:25 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc
File src/kudu/util/monotime.cc:

http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc@355
PS1, Line 355: os_ns << ts.tv_ns
> Oh meant in the output of the ostringstream and not in the naming of the va
Yep, I guess it makes sense to keep the name of the parameter as 'os' at least to keep it in sync between the header and this file.



-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 22 Oct 2021 23:59:08 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17961

to look at the new patch set (#3).

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................

KUDU-3330 Define operator<< for MonoTime

This patch implements the operator<< for MonoTime. This is needed for
CHECK_XX and DCHECK_XX on MonoTime.

Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
---
M src/kudu/util/monotime.cc
M src/kudu/util/monotime.h
2 files changed, 23 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/17961/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17961

to look at the new patch set (#4).

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................

KUDU-3330 Define operator<< for MonoTime

This patch implements the operator<< for MonoTime. This is needed for
CHECK_XX and DCHECK_XX on MonoTime.

Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
---
M src/kudu/util/monotime.cc
M src/kudu/util/monotime.h
2 files changed, 23 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/17961/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [KUDU-3330] Define operator<< for MonoTime

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )

Change subject: [KUDU-3330] Define operator<< for MonoTime
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc
File src/kudu/util/monotime.cc:

http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc@355
PS1, Line 355: os << ts.tv_nsec;
Do we need a suffix that suggests this timestamp is in nanoseconds like "ns"?



-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 Oct 2021 17:26:58 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17961

to look at the new patch set (#2).

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................

KUDU-3330 Define operator<< for MonoTime

This patch implements the operator<< for MonoTime. This is needed for
CHECK_XX and DCHECK_XX on MonoTime.

Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
---
M src/kudu/util/monotime.cc
M src/kudu/util/monotime.h
2 files changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/17961/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17961

to look at the new patch set (#5).

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................

KUDU-3330 Define operator<< for MonoTime

This patch implements the operator<< for MonoTime. This is needed for
CHECK_XX and DCHECK_XX on MonoTime.

Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
---
M src/kudu/util/monotime.cc
M src/kudu/util/monotime.h
2 files changed, 24 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/17961/5
-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................


Patch Set 4: Code-Review+2

Fix the IWYU issue and ship it!


-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Oct 2021 17:52:32 +0000
Gerrit-HasComments: No

[kudu-CR] [KUDU-3330] Define operator<< for MonoTime

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )

Change subject: [KUDU-3330] Define operator<< for MonoTime
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17961/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17961/1//COMMIT_MSG@7
PS1, Line 7: ]
Will drop the parenthesis in the next revision of this patch.


http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc
File src/kudu/util/monotime.cc:

http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc@355
PS1, Line 355: os << ts.tv_nsec;
> Do we need a suffix that suggests this timestamp is in nanoseconds like "ns
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 22 Oct 2021 16:08:44 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Oct 2021 20:29:47 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h
File src/kudu/util/monotime.h:

http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h@499
PS2, Line 499: An ostream object which will store the nanoseconds of MonoTime.
> how about:
Done


http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h@501
PS2, Line 501: A MonoTime object which has to be converted to ostream.
> how about:
Done


http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h@503
PS2, Line 503: , time
> nit: drop this?
Done


http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.h
File src/kudu/util/monotime.h:

http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.h@493
PS1, Line 493: 
             : /// @name Syntactic sugar: ostream operator for MonoTime.
             : ///@{
> Since that's not a part of public API (no KUDU_EXPORT), it makes sense to a
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 22 Oct 2021 18:56:32 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h
File src/kudu/util/monotime.h:

http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h@499
PS2, Line 499: An ostream object which will store the nanoseconds of MonoTime.
how about:
  An ostream output object.


http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h@501
PS2, Line 501: A MonoTime object which has to be converted to ostream.
how about:
  A MonoTime object to output.


http://gerrit.cloudera.org:8080/#/c/17961/2/src/kudu/util/monotime.h@503
PS2, Line 503: , time
nit: drop this?


http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.h
File src/kudu/util/monotime.h:

http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.h@493
PS1, Line 493: 
             : /// @name Syntactic sugar: ostream operator for MonoTime.
             : ///@{
Since that's not a part of public API (no KUDU_EXPORT), it makes sense to annotate this method as private so it's not shown in the auto-generated docs.

See https://github.com/apache/kudu/blob/0ade8c6f21f0887e90b261ae6b1a57f4a6d1eff1/src/kudu/client/client.h#L1045-L1052 for an example how to annotate this fact.  I guess it's worth removing that 'Syntactic sugar' scope and replace it with the PRIVATE_API doxygen conditional.



-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 22 Oct 2021 16:45:50 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc
File src/kudu/util/monotime.cc:

http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc@355
PS1, Line 355: os_ns << ts.tv_ns
> Done
Oh meant in the output of the ostringstream and not in the naming of the variable.



-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 22 Oct 2021 19:44:05 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17961 )

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................

KUDU-3330 Define operator<< for MonoTime

This patch implements the operator<< for MonoTime. This is needed for
CHECK_XX and DCHECK_XX on MonoTime.

Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Reviewed-on: http://gerrit.cloudera.org:8080/17961
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/monotime.cc
M src/kudu/util/monotime.h
2 files changed, 24 insertions(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Bankim Bhavsar: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-3330 Define operator<< for MonoTime

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17961 )

Change subject: KUDU-3330 Define operator<< for MonoTime
......................................................................


Patch Set 5:

(1 comment)

Fixed IWYU

http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc
File src/kudu/util/monotime.cc:

http://gerrit.cloudera.org:8080/#/c/17961/1/src/kudu/util/monotime.cc@355
PS1, Line 355: time.ToTimeSpec(&
> Yep, I guess it makes sense to keep the name of the parameter as 'os' at le
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I729c8a81c52ad800680187b89db1d224b7aec769
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 25 Oct 2021 19:46:38 +0000
Gerrit-HasComments: Yes