[GitHub] [hive] pgaref commented on a change in pull request #1982: HIVE-24778: Unify hive.strict.timestamp.conversion and hive.strict.checks.type.safety properties

[GitBox <gi...@apache.org>]

pgaref commented on a change in pull request #1982:
URL: https://github.com/apache/hive/pull/1982#discussion_r577705382



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/udf/TimestampCastRestrictorResolver.java
##########
@@ -45,7 +45,7 @@
   public TimestampCastRestrictorResolver(UDFMethodResolver parentResolver) {
     this.parentResolver = parentResolver;
     SessionState ss = SessionState.get();
-    if (ss != null && ss.getConf().getBoolVar(ConfVars.HIVE_STRICT_TIMESTAMP_CONVERSION)) {
+    if (ss != null && ss.getConf().getBoolVar(ConfVars.HIVE_STRICT_CHECKS_TYPE_SAFETY)) {

Review comment:
       Hey @zabetak -- had a chat with @kgyrtkirk  regarding this.
   Seems like udfs do not communicate their accepted format/s as they may introduce converters/Bridges/etc during initialization.
   This is why HIVE-24157 introduced this  restriction as part of the in the resolver




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org