You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "convoi (via GitHub)" <gi...@apache.org> on 2023/06/27 11:40:39 UTC
[GitHub] [arrow] convoi opened a new pull request, #36322: GH-36318: [Go] only decode lengths for the number of existing values, not for all nvalues.
convoi opened a new pull request, #36322:
URL: https://github.com/apache/arrow/pull/36322
### Rationale for this change
Fixes issue 36318.
DeltaLengthBinaryArray Encoding fails to handle null values.
### What changes are included in this PR?
Instead of decoding lengths for "all" values (even the undefined ones), we only decode the lengths for the actually set values.
The Go Version of arrow was unable to read parquet files it produced itself if the mentioned encoding was used but the values contain nulls.
### Are these changes tested?
Tests are included.
### Are there any user-facing changes?
No.
**This PR contains a "Critical Fix".**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36322: GH-36318: [Go] only decode lengths for the number of existing values, not for all nvalues.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36322:
URL: https://github.com/apache/arrow/pull/36322#issuecomment-1609330613
:warning: GitHub issue #36318 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a diff in pull request #36322: GH-36318: [Go] only decode lengths for the number of existing values, not for all nvalues.
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #36322:
URL: https://github.com/apache/arrow/pull/36322#discussion_r1249625345
##########
go/parquet/internal/encoding/delta_byte_array_test.go:
##########
@@ -0,0 +1,31 @@
+package encoding
Review Comment:
You need to add the Apache license to the top of this file please. That will fix the failing CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36322: GH-36318: [Go] only decode lengths for the number of existing values, not for all nvalues.
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36322:
URL: https://github.com/apache/arrow/pull/36322#issuecomment-1649933448
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 2c2333c085d0d026ac9cb86eb709662c236df0d8.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/15328207418) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #36322: GH-36318: [Go] only decode lengths for the number of existing values, not for all nvalues.
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #36322:
URL: https://github.com/apache/arrow/pull/36322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org