You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/01 09:40:17 UTC
[GitHub] [spark] yaooqinn opened a new pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved properties of tables
yaooqinn opened a new pull request #32025:
URL: https://github.com/apache/spark/pull/32025
…
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
CREATE TABLE LIKE should respect the reserved properties of tables and fail if specified, using `spark.sql.legacy.notReserveProperties` to restore.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Make DDLs consistently treat reserved properties
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
YES, this is a breaking change as using `create table like` w/ reserved properties will fail.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-811958685
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136809/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on a change in pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32025:
URL: https://github.com/apache/spark/pull/32025#discussion_r607132932
##########
File path: docs/sql-migration-guide.md
##########
@@ -73,6 +73,8 @@ license: |
- In Spark 3.2, the timestamps subtraction expression such as `timestamp '2021-03-31 23:48:00' - timestamp '2021-01-01 00:00:00'` returns values of `DayTimeIntervalType`. In Spark 3.1 and earlier, the type of the same expression is `CalendarIntervalType`. To restore the behavior before Spark 3.2, you can set `spark.sql.legacy.interval.enabled` to `true`.
+ - In Spark 3.2, `CREATE TABLE .. LIKE ..` command can not use reserved properties. You need their specific clauses to specify them, for example, `CREATE TABLE test1 LIKE test LOCATION 'some path'`. You can set `spark.sql.legacy.notReserveProperties` to `true` to ignore the `ParseException`, in this case, these properties will be silently removed, for example: `TBLPROPERTIES('owner'='yao')` will have no effect. In Spark version 3.1 and below, the reserved properties are only affect other DDLs except for this one, for example, `TBLPROPERTIES('location'='/tmp')` does not change the location of the table but only create a headless property just like `'a'='b'`.
+
Review comment:
It's a typo, let me fix it:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-811825648
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41392/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-813714952
Thanks! Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-813588456
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136913/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-813443974
**[Test build #136913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136913/testReport)** for PR 32025 at commit [`0cf2ce1`](https://github.com/apache/spark/commit/0cf2ce1efc5344deace91a29795fe3afb7658276).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-811792687
**[Test build #136809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136809/testReport)** for PR 32025 at commit [`bb5ca65`](https://github.com/apache/spark/commit/bb5ca6510dfd6994e32d37f63e17c33f371276ed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-813443974
**[Test build #136913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136913/testReport)** for PR 32025 at commit [`0cf2ce1`](https://github.com/apache/spark/commit/0cf2ce1efc5344deace91a29795fe3afb7658276).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-811840988
cc @cloud-fan @maropu thanks for reviewing, I guess we can make a document for reserved properties for DDL pages to refer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32025:
URL: https://github.com/apache/spark/pull/32025#discussion_r607131606
##########
File path: docs/sql-migration-guide.md
##########
@@ -73,6 +73,8 @@ license: |
- In Spark 3.2, the timestamps subtraction expression such as `timestamp '2021-03-31 23:48:00' - timestamp '2021-01-01 00:00:00'` returns values of `DayTimeIntervalType`. In Spark 3.1 and earlier, the type of the same expression is `CalendarIntervalType`. To restore the behavior before Spark 3.2, you can set `spark.sql.legacy.interval.enabled` to `true`.
+ - In Spark 3.2, `CREATE TABLE .. LIKE ..` command can not use reserved properties. You need their specific clauses to specify them, for example, `CREATE TABLE test1 LIKE test LOCATION 'some path'`. You can set `spark.sql.legacy.notReserveProperties` to `true` to ignore the `ParseException`, in this case, these properties will be silently removed, for example: `TBLPROPERTIES('owner'='yao')` will have no effect. In Spark version 3.1 and below, the reserved properties are only affect other DDLs except for this one, for example, `TBLPROPERTIES('location'='/tmp')` does not change the location of the table but only create a headless property just like `'a'='b'`.
+
Review comment:
`the reserved properties are only affect other DDLs except for this one` what does it mean? What's "this one"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-813587360
**[Test build #136913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136913/testReport)** for PR 32025 at commit [`0cf2ce1`](https://github.com/apache/spark/commit/0cf2ce1efc5344deace91a29795fe3afb7658276).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn edited a comment on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
yaooqinn edited a comment on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-811840988
cc @cloud-fan @maropu thanks for reviewing, I guess later we can make a document for reserved properties for DDL pages to refer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-811825619
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41392/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #32025:
URL: https://github.com/apache/spark/pull/32025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-813472337
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41490/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-813465066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-811931047
**[Test build #136809 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136809/testReport)** for PR 32025 at commit [`bb5ca65`](https://github.com/apache/spark/commit/bb5ca6510dfd6994e32d37f63e17c33f371276ed).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-811792687
**[Test build #136809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136809/testReport)** for PR 32025 at commit [`bb5ca65`](https://github.com/apache/spark/commit/bb5ca6510dfd6994e32d37f63e17c33f371276ed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-813472337
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41490/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-813588456
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136913/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-811821764
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41392/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-811825648
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41392/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32025: [SPARK-34935][SQL] CREATE TABLE LIKE should respect the reserved table properties
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32025:
URL: https://github.com/apache/spark/pull/32025#issuecomment-811958685
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136809/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org