[jira] [Commented] (LUCENE-7500) Nuke Fields.java in lieu of LeafReader.getTerms(fieldName)

["Adrien Grand (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582426#comment-15582426 ] 

Adrien Grand commented on LUCENE-7500:
--------------------------------------

I just looked again at how Fields are used, and I'd be tempted to just remove {{LeafReader.fields()}}. Consumers would have to call {{LeafReader.terms(String)}} instead. Fields would still be useful in {{CodecReader.getPostingsReader()}} (consistently with {{getNormsReader}}, {{getPointsReader}}, {{getDocValuesReader}} which all deal with all fields at once) and {{LeafReader.getTermVectors(int)}} for term vectors.



> Nuke Fields.java in lieu of LeafReader.getTerms(fieldName)
> ----------------------------------------------------------
>
>                 Key: LUCENE-7500
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7500
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: David Smiley
>             Fix For: master (7.0)
>
>
> {{Fields}} seems like a pointless intermediary between the {{LeafReader}} and {{Terms}}. Why not have {{LeafReader.getTerms(fieldName)}} instead? One loses the ability to get the count and iterate over indexed fields, but it's not clear what real use-cases are for that and such rare needs could figure that out with FieldInfos.
> [~mikemccand] pointed out that we'd probably need to re-introduce a {{TermVectors}} class since TV's are row-oriented not column-oriented.  IMO they should be column-oriented but that'd be a separate issue.
> _(p.s. I'm lacking time to do this w/i the next couple months so if someone else wants to tackle it then great)_



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org