You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/05/04 18:27:25 UTC

[Impala-ASF-CR] IMPALA-9630 Keep blocking queue cache line aligned on aarch64

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15705 )

Change subject: IMPALA-9630 Keep blocking queue cache line aligned on aarch64
......................................................................


Patch Set 4:

(1 comment)

SOrry for the slow turnaround on the review

http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h
File be/src/common/compiler-util.h:

http://gerrit.cloudera.org:8080/#/c/15705/4/be/src/common/compiler-util.h@21
PS4, Line 21: #include "gutil/port.h"
> Hi, Tim, except the blocking-queue.h, there are also other files use this C
Yep, that would be great



-- 
To view, visit http://gerrit.cloudera.org:8080/15705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia169e15d3a225f1e4780e671b8cce680b176c171
Gerrit-Change-Number: 15705
Gerrit-PatchSet: 4
Gerrit-Owner: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Anonymous Coward <zh...@hotmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 May 2020 18:27:25 +0000
Gerrit-HasComments: Yes