[GitHub] [ozone] adoroszlai commented on a change in pull request #3052: HDDS-6235. Empty KeyValueContainers are replicated without chunks directory.

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #3052:
URL: https://github.com/apache/ozone/pull/3052#discussion_r810168011



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/TarContainerPacker.java
##########
@@ -84,11 +84,19 @@
         if (name.startsWith(DB_DIR_NAME + "/")) {
           Path destinationPath = dbRoot
               .resolve(name.substring(DB_DIR_NAME.length() + 1));
-          extractEntry(archiveInput, size, dbRoot, destinationPath);
+          if (entry.isDirectory()) {
+            Files.createDirectories(destinationPath);
+          } else {
+            extractFileEntry(archiveInput, size, dbRoot, destinationPath);
+          }

Review comment:
       Nit: can we move this logic to `extractEntry` (and keep the method name) to avoid duplication?

##########
File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainer.java
##########
@@ -244,6 +268,18 @@ public void testContainerImportExport() throws Exception {
     }
   }
 
+  private void checkContainerFilesPresent(KeyValueContainerData data,

Review comment:
       Nit: this method seems to be unused.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org