You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/05/28 19:51:02 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #4320: Disable backlog quota check by default.

merlimat commented on a change in pull request #4320: Disable backlog quota check by default.
URL: https://github.com/apache/pulsar/pull/4320#discussion_r288274041
 
 

 ##########
 File path: conf/broker.conf
 ##########
 @@ -68,13 +68,13 @@ zooKeeperOperationTimeoutSeconds=30
 brokerShutdownTimeoutMs=60000
 
 # Enable backlog quota check. Enforces action on topic when the quota is reached
-backlogQuotaCheckEnabled=true
+backlogQuotaCheckEnabled=false
 
 Review comment:
   This will also disable custom quota checks on namespaces. I think we should have a way to set `backlogQuotaDefaultLimitGB` to -1 for disabling the quota check by default. That would require some small adjustment in the code check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services