[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1011: DISPATCH-1942 Use findPython when on CMake3.15+

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #1011:
URL: https://github.com/apache/qpid-dispatch/pull/1011#discussion_r577753463



##########
File path: CMakeLists.txt
##########
@@ -102,31 +108,29 @@ if (LIBWEBSOCKETS_FOUND AND LIBWEBSOCKETS_VERSION_STRING)
 endif(LIBWEBSOCKETS_FOUND AND LIBWEBSOCKETS_VERSION_STRING)
 
 # Python
-if (PYTHON_VERSION_MAJOR STREQUAL 3)
+if (Python_VERSION_MAJOR STREQUAL 3)
     set(PY_STRING "python3")
-elseif(PYTHON_VERSION_MAJOR STREQUAL 2)
+elseif(Python_VERSION_MAJOR STREQUAL 2)
     set(PY_STRING "python")
 endif()
 
-enable_testing()
-
 # python unittest
 # For versions < 2.7 the developer needs to install the unittest2

Review comment:
       Thanks for the notice. I'll rebase the PR when I'm at a computer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org