You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by cc...@apache.org on 2024/10/10 23:24:34 UTC

(yunikorn-core) branch master updated: [YUNIKORN-2917] Add additional buckets for latency histograms (#982)

This is an automated email from the ASF dual-hosted git repository.

ccondit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/yunikorn-core.git


The following commit(s) were added to refs/heads/master by this push:
     new 86dd867f [YUNIKORN-2917] Add additional buckets for latency histograms (#982)
86dd867f is described below

commit 86dd867fb2fd0628701a520be41510684252f227
Author: Craig Condit <cc...@apache.org>
AuthorDate: Thu Oct 10 17:24:21 2024 -0600

    [YUNIKORN-2917] Add additional buckets for latency histograms (#982)
    
    Update latency histograms to allow buckets for larger (> 10s) values.
    Also update descriptions to reflect that despite the naming, the values
    are, in fact, specified in seconds.
    
    Existing names are retained to avoid breaking backwards compatibility.
    
    Closes: #982
---
 pkg/metrics/scheduler.go | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/pkg/metrics/scheduler.go b/pkg/metrics/scheduler.go
index b0999a40..15342905 100644
--- a/pkg/metrics/scheduler.go
+++ b/pkg/metrics/scheduler.go
@@ -113,8 +113,8 @@ func InitSchedulerMetrics() *SchedulerMetrics {
 			Namespace: Namespace,
 			Subsystem: SchedulerSubsystem,
 			Name:      "scheduling_latency_milliseconds",
-			Help:      "Latency of the main scheduling routine, in milliseconds.",
-			Buckets:   prometheus.ExponentialBuckets(0.0001, 10, 6), // start from 0.1ms
+			Help:      "Latency of the main scheduling routine, in seconds.",
+			Buckets:   prometheus.ExponentialBuckets(0.0001, 10, 8), // start from 0.1ms
 		},
 	)
 	s.sortingLatency = prometheus.NewHistogramVec(
@@ -122,8 +122,8 @@ func InitSchedulerMetrics() *SchedulerMetrics {
 			Namespace: Namespace,
 			Subsystem: SchedulerSubsystem,
 			Name:      "node_sorting_latency_milliseconds",
-			Help:      "Latency of all nodes sorting, in milliseconds.",
-			Buckets:   prometheus.ExponentialBuckets(0.0001, 10, 6), // start from 0.1ms
+			Help:      "Latency of all nodes sorting, in seconds.",
+			Buckets:   prometheus.ExponentialBuckets(0.0001, 10, 8), // start from 0.1ms
 		}, []string{"level"})
 
 	s.tryNodeLatency = prometheus.NewHistogram(
@@ -131,8 +131,8 @@ func InitSchedulerMetrics() *SchedulerMetrics {
 			Namespace: Namespace,
 			Subsystem: SchedulerSubsystem,
 			Name:      "trynode_latency_milliseconds",
-			Help:      "Latency of node condition checks for container allocations, such as placement constraints, in milliseconds.",
-			Buckets:   prometheus.ExponentialBuckets(0.0001, 10, 6),
+			Help:      "Latency of node condition checks for container allocations, such as placement constraints, in seconds.",
+			Buckets:   prometheus.ExponentialBuckets(0.0001, 10, 8),
 		},
 	)
 
@@ -141,8 +141,8 @@ func InitSchedulerMetrics() *SchedulerMetrics {
 			Namespace: Namespace,
 			Subsystem: SchedulerSubsystem,
 			Name:      "trypreemption_latency_milliseconds",
-			Help:      "Latency of preemption condition checks for container allocations, in milliseconds.",
-			Buckets:   prometheus.ExponentialBuckets(0.0001, 10, 6),
+			Help:      "Latency of preemption condition checks for container allocations, in seconds.",
+			Buckets:   prometheus.ExponentialBuckets(0.0001, 10, 8),
 		},
 	)
 


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org