You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by st...@apache.org on 2014/03/26 22:27:49 UTC

[02/20] git commit: CB-6281 - correcting the plugin details, having controller now pull in extra fields for keywords, platforms, and maintainers. As well as fixing some column styles on viewall, plugindetails, index.html

CB-6281 - correcting the plugin details, having controller now pull in extra fields for keywords, platforms, and maintainers. As well as fixing some column styles on viewall, plugindetails, index.html


Project: http://git-wip-us.apache.org/repos/asf/cordova-registry-web/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-registry-web/commit/70a373b5
Tree: http://git-wip-us.apache.org/repos/asf/cordova-registry-web/tree/70a373b5
Diff: http://git-wip-us.apache.org/repos/asf/cordova-registry-web/diff/70a373b5

Branch: refs/heads/refactor
Commit: 70a373b5baa2aba500281423a83c2c01a6ae5bcb
Parents: 2a45465
Author: Josh Bavari <jo...@raisemore.com>
Authored: Sun Mar 16 23:34:48 2014 -0500
Committer: Josh Bavari <jo...@raisemore.com>
Committed: Sun Mar 16 23:34:48 2014 -0500

----------------------------------------------------------------------
 attachments/index.html                          |   3 +-
 attachments/js/controllers/packageDetails.js    |   9 ++
 attachments/partials/directives/pluginlist.html |   2 +-
 attachments/partials/views/home.html            |   2 +-
 attachments/partials/views/packageDetails.html  | 100 +++++++++++++------
 attachments/partials/views/search.html          |  28 +++---
 attachments/partials/views/viewAll.html         |  10 +-
 7 files changed, 103 insertions(+), 51 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-registry-web/blob/70a373b5/attachments/index.html
----------------------------------------------------------------------
diff --git a/attachments/index.html b/attachments/index.html
index 35c90f8..a47749a 100644
--- a/attachments/index.html
+++ b/attachments/index.html
@@ -12,6 +12,7 @@
   <title>Cordova Plugin Registry</title>
   <!-- <link rel="stylesheet" type="text/css" href="css/topcoat-mobile-light.min.css" /> -->
   <!-- <link rel="stylesheet" type="text/css" href="css/grid.min.css"> -->
+  <link href='http://fonts.googleapis.com/css?family=Lato:100,300,400' rel='stylesheet' type='text/css'>
   <link href="css/styles.css" rel="stylesheet" type="text/css">
   <link href="images/favicon.ico" rel="shortcut icon" type="image/x-icon">
 
@@ -19,7 +20,7 @@
 
 </head>
 
-<body ng-app='registry'>
+<body ng-app="registry">
 
   <div id="header" class="">
     <div class="header-content row">

http://git-wip-us.apache.org/repos/asf/cordova-registry-web/blob/70a373b5/attachments/js/controllers/packageDetails.js
----------------------------------------------------------------------
diff --git a/attachments/js/controllers/packageDetails.js b/attachments/js/controllers/packageDetails.js
index 49cb5b5..c0e8c9f 100644
--- a/attachments/js/controllers/packageDetails.js
+++ b/attachments/js/controllers/packageDetails.js
@@ -14,6 +14,8 @@ angular.module('registry.controllers').controller('PackageDetailsController', ['
     $scope.downloads = null;
     $scope.latestVersion = null;
     $scope.currentVersion = "0.2.6";
+    $scope.platforms = null;
+    $scope.keywords = null;
 
     $scope.getPackage = function(){
         console.log($scope.packageID);
@@ -25,6 +27,9 @@ angular.module('registry.controllers').controller('PackageDetailsController', ['
                     $scope.currentVersion = $scope.latestVersion;
                     $scope.issue = $scope.data.versions[$scope.currentVersion].issue;
                     $scope.repo = $scope.data.versions[$scope.currentVersion].repo;
+                    $scope.maintainers = $scope.data.versions[$scope.currentVersion].maintainers;
+                    $scope.platforms = $scope.data.versions[$scope.currentVersion].platforms;
+                    $scope.keywords = $scope.data.versions[$scope.currentVersion].keywords;
                     $scope.versions = $scope.data.versions;
                     console.log(data); 
                     console.log($scope.versions);
@@ -46,6 +51,10 @@ angular.module('registry.controllers').controller('PackageDetailsController', ['
             $scope.issue = $scope.data.versions[$scope.currentVersion].issue;
             $scope.repo = $scope.data.versions[$scope.currentVersion].repo;
             $scope.description = $scope.data.versions[$scope.currentVersion].description;
+            $scope.maintainers = $scope.data.versions[$scope.currentVersion].maintainers;
+            $scope.platforms = $scope.data.versions[$scope.currentVersion].platforms;
+            $scope.keywords = $scope.data.versions[$scope.currentVersion].keywords;
+
             if($scope.currentVersion === $scope.latestVersion){
                 $scope.packageID = $routeParams.id
             }else{

http://git-wip-us.apache.org/repos/asf/cordova-registry-web/blob/70a373b5/attachments/partials/directives/pluginlist.html
----------------------------------------------------------------------
diff --git a/attachments/partials/directives/pluginlist.html b/attachments/partials/directives/pluginlist.html
index 7cfa7a0..5697ee7 100644
--- a/attachments/partials/directives/pluginlist.html
+++ b/attachments/partials/directives/pluginlist.html
@@ -1,7 +1,7 @@
 <div ng-show="plugins.length > 0">
     <div class="row pluginHeader">
         <div class="column-9--hand column-8--lap">
-            <h3>Plugin ID & description</h3>
+            <h3>Plugin ID &amp; description</h3>
         </div>
         <div class="column-3--hand column-2--lap center">
             <h3>Version</h3>

http://git-wip-us.apache.org/repos/asf/cordova-registry-web/blob/70a373b5/attachments/partials/views/home.html
----------------------------------------------------------------------
diff --git a/attachments/partials/views/home.html b/attachments/partials/views/home.html
index 336c36e..ff809b4 100644
--- a/attachments/partials/views/home.html
+++ b/attachments/partials/views/home.html
@@ -1,5 +1,5 @@
 <div id="home-container">
-	<div class="cordova-grid-bg ">
+	<div class="cordova-grid-bg">
         <div class="row discover-message-container visible--lap invisible--hand">
 			<div class="column-7--lap column-6--desk offset-2--lap">
 				<p class="discover-message">Discover plugins for your </h1>

http://git-wip-us.apache.org/repos/asf/cordova-registry-web/blob/70a373b5/attachments/partials/views/packageDetails.html
----------------------------------------------------------------------
diff --git a/attachments/partials/views/packageDetails.html b/attachments/partials/views/packageDetails.html
index 19f97a3..50277ba 100644
--- a/attachments/partials/views/packageDetails.html
+++ b/attachments/partials/views/packageDetails.html
@@ -1,49 +1,85 @@
-<div class="viewContainer">
-    <div class="row toprow">
-        <div class="package-label column-8--hand">Plugin ID</div>
-        <div class="column-4--hand right">
-            <select ng-model="currentVersion" ng-options="key as key for (key, value) in versions">
-                <option value="{{currentVersion}}">{{currentVersion}}</option> 
-            </select>
-        </div>
+<div class="viewContainer row">
+    <div class="column-8--hand offset-2--hand">
 
-    </div>
-    <div class="row">
-        <div class="package-title column-12--hand">{{packageID}}</div>
-    </div>
+        <a ng-click="backToSearch()">Back to search results</a>
+
+        <div class="row toprow">
+            <div class="package-label column-8--hand">Plugin ID</div>
+            <div class="column-4--hand right">
+                <select ng-model="currentVersion" ng-options="key as key for (key, value) in versions">
+                    <option value="{{currentVersion}}">{{currentVersion}}</option> 
+                </select>
+            </div>
 
-    <div ng-show="description" class="space">
-        <div class="row">
-            <div class="package-label column-12--hand">Description</div>
         </div>
         <div class="row">
-            <div class="package-title column-12--hand">{{description}}</div>
+            <div class="package-title column-12--hand">{{packageID}}</div>
         </div>
-    </div>
 
+        <div ng-show="description" class="space">
+            <div class="row">
+                <div class="package-label column-12--hand">Description</div>
+            </div>
+            <div class="row">
+                <div class="package-title column-12--hand">{{description}}</div>
+            </div>
+        </div>
 
+        <div ng-show="maintainers" class="space">
+            <div class="row">
+                <div class="package-label column-12--hand">Maintainers</div>
+            </div>
+            <div class="row">
+                <div class="column-12--hand">
+                    <span class="" ng-repeat="maintainer in maintainers">{{maintainer.name}}<span ng-show="{{maintainers.length -1 != $index}}">, &nbsp;</span></span>
+                </div>
+            </div>
+        </div>
 
-    <div ng-show="repo" class="space">
-        <div class="row">
-            <div class="package-label column-12--hand">Repository</div>
+        <div ng-show="platforms" class="space">
+            <div class="row">
+                <div class="package-label column-12--hand">Platforms</div>
+            </div>
+            <div class="row">
+                <div class="column-12--hand">
+                    <span class="" ng-repeat="platform in platforms">{{platform}}<span ng-show="{{platforms.length -1 != $index}}">, &nbsp;</span></span>
+                </div>
+            </div>
         </div>
-        <div class="row">
-            <div class="column-12--hand"><a href={{repo}}>{{repo}}</a></div>
+
+        <div ng-show="repo" class="space">
+            <div class="row">
+                <div class="package-label column-12--hand">Repository</div>
+            </div>
+            <div class="row">
+                <div class="column-12--hand"><a href="{{repo}}">{{repo}}</a></div>
+            </div>
         </div>
-    </div>
 
-    <div ng-show="issue" class="space">
-        <div class="row">
-            <div class="package-label column-12--hand">Issue tracker</div>
+        <div ng-show="issue" class="space">
+            <div class="row">
+                <div class="package-label column-12--hand">Issue tracker</div>
+            </div>
+            <div class="row">
+                <div class="column-12--hand"><a href="{{issue}}">{{issue}}</a></div>
+            </div>
         </div>
-        <div class="row">
-            <div class="column-12--hand"><a href={{issue}}>{{issue}}</a></div>
+
+        <div ng-show="platforms" class="space">
+            <div class="row">
+                <div class="package-label column-12--hand">Keywords</div>
+            </div>
+            <div class="row">
+                <div class="column-12--hand">
+                    <span class="" ng-repeat="keyword in keywords">{{keyword}}<span ng-show="{{keywords.length -1 != $index}}">, &nbsp;</span></span>
+                </div>
+            </div>
         </div>
-    </div>
 
-    <div ng-show="readme" class="readme">
-        <div class="package-readme">Read Me</div>
-        <div class="" ng-bind-html="readme"></div>
+        <div ng-show="readme" class="readme">
+            <div class="package-readme">Read Me</div>
+            <div class="" ng-bind-html="readme"></div>
+        </div>
     </div>
 </div>
 

http://git-wip-us.apache.org/repos/asf/cordova-registry-web/blob/70a373b5/attachments/partials/views/search.html
----------------------------------------------------------------------
diff --git a/attachments/partials/views/search.html b/attachments/partials/views/search.html
index d2ba32f..2ea8fb4 100644
--- a/attachments/partials/views/search.html
+++ b/attachments/partials/views/search.html
@@ -1,19 +1,21 @@
 <topbar></topbar>
-<div class="searchContainer">
-    <div class="row">
-        <div class="column-12--hand found">
-        <ng-pluralize count="plugins.length"
-            when="{'0': 'No plugins found',
-                '1': '1 plugin found',
-                'other': '{{plugins.length}} plugins found'}">
-        </ng-pluralize>
+<div class="searchContainer row">
+    <div class="offset-2--hand column-8--hand">
+        <div class="row">
+            <div class="column-12--hand found">
+            <ng-pluralize count="plugins.length"
+                when="{'0': 'No plugins found',
+                    '1': '1 plugin found',
+                    'other': '{{plugins.length}} plugins found'}">
+            </ng-pluralize>
+            </div>
         </div>
-    </div>
 
-<!--<div class="row">
-        <a href="">Filter by Platform:</a> All
-    </div>-->
+    <!--<div class="row">
+            <a href="">Filter by Platform:</a> All
+        </div>-->
 
-    <pluginlist></pluginlist>
+        <pluginlist></pluginlist>
+    </div>
 </div>
 

http://git-wip-us.apache.org/repos/asf/cordova-registry-web/blob/70a373b5/attachments/partials/views/viewAll.html
----------------------------------------------------------------------
diff --git a/attachments/partials/views/viewAll.html b/attachments/partials/views/viewAll.html
index 8e7e654..30c1306 100644
--- a/attachments/partials/views/viewAll.html
+++ b/attachments/partials/views/viewAll.html
@@ -1,4 +1,8 @@
 <topbar></topbar>
-<div class="viewContainer">
-    <pluginlist></pluginlist>
-</div>
+<div class="row">
+	<div class="offset-2--hand column-8--hand">
+		<div class="viewContainer">
+		    <pluginlist></pluginlist>
+		</div>
+	</div>
+</div>
\ No newline at end of file